Quantcast

Another commit for master

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Another commit for master

Paul Licameli
Gale discovered that 6b65375 now causes the temporary projectNNNNN.. folder in SessionData to linger after the new untitled project is saved elsewhere.  Lingers until closing of the last project window.

I should have seen that coming.  I have written the correction for that.

The fix is at the tip of my branch bug1567-simple, and its id is:



5392feefd4c9e0f9952fc2328a303d8f8614f319



PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another commit for master

James Crook
Pushed tip of branch bug1567-simple to master.
I chose to include the updated comment, as it is safe and improves matters.
--James.

On 1/31/2017 5:47 PM, Paul Licameli wrote:

> Gale discovered that 6b65375 now causes the temporary projectNNNNN.. folder
> in SessionData to linger after the new untitled project is saved
> elsewhere.  Lingers until closing of the last project window.
>
> I should have seen that coming.  I have written the correction for that.
>
> The fix is at the tip of my branch bug1567-simple, and its id is:
>
>
>
> 5392feefd4c9e0f9952fc2328a303d8f8614f319
>
>
>
> PRL
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another commit for master

Gale
Administrator
On 31 January 2017 at 22:25, James Crook <[hidden email]> wrote:
> Pushed tip of branch bug1567-simple to master.
> I chose to include the updated comment, as it is safe and improves matters.
> --James.

This works for me. Even if the project you save is not the last, its
project folder is removed, and 1567 doesn't occur.

This now reduces 1521 (and thus 1567) to the case of close without
save on any project except the last (irresepctive of how the project's
audio was created).



Gale


> On 1/31/2017 5:47 PM, Paul Licameli wrote:
>> Gale discovered that 6b65375 now causes the temporary projectNNNNN.. folder
>> in SessionData to linger after the new untitled project is saved
>> elsewhere.  Lingers until closing of the last project window.
>>
>> I should have seen that coming.  I have written the correction for that.
>>
>> The fix is at the tip of my branch bug1567-simple, and its id is:
>>
>>
>>
>> 5392feefd4c9e0f9952fc2328a303d8f8614f319
>>
>>
>>
>> PRL
>>
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another commit for master

Paul Licameli
Gale, just to eliminate confustion, what is the commit that you last tested?

Commit 1469045 is the last thing I wrote, the most comprehensive fix, but also one that James and I suspect isn't yet probaly safe, and we (tacitly at least) agreed not to merge into master for RC1.  I wrote that after I wrote the email above in this thread.  I told the team about that in a different thread.

PRL


On Thu, Feb 2, 2017 at 1:39 PM, Gale Andrews <[hidden email]> wrote:
On 31 January 2017 at 22:25, James Crook <[hidden email]> wrote:
> Pushed tip of branch bug1567-simple to master.
> I chose to include the updated comment, as it is safe and improves matters.
> --James.

This works for me. Even if the project you save is not the last, its
project folder is removed, and 1567 doesn't occur.

This now reduces 1521 (and thus 1567) to the case of close without
save on any project except the last (irresepctive of how the project's
audio was created).



Gale


> On 1/31/2017 5:47 PM, Paul Licameli wrote:
>> Gale discovered that 6b65375 now causes the temporary projectNNNNN.. folder
>> in SessionData to linger after the new untitled project is saved
>> elsewhere.  Lingers until closing of the last project window.
>>
>> I should have seen that coming.  I have written the correction for that.
>>
>> The fix is at the tip of my branch bug1567-simple, and its id is:
>>
>>
>>
>> 5392feefd4c9e0f9952fc2328a303d8f8614f319
>>
>>
>>
>> PRL
>>
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another commit for master

Gale
Administrator
On 2 February 2017 at 20:12, Paul Licameli <[hidden email]> wrote:
> Gale, just to eliminate confustion, what is the commit that you last tested?
>
> Commit 1469045 is the last thing I wrote, the most comprehensive fix, but
> also one that James and I suspect isn't yet probaly safe, and we (tacitly at
> least) agreed not to merge into master for RC1.  I wrote that after I wrote
> the email above in this thread.  I told the team about that in a different
> thread.

I'm talking about HEAD as it appears in jc11.dmg. In other words, even
without your "1469045", save project now always totally cleans up that
project in SessionData, leaving no folder at all, even if there are other
projects open.

That;s what we now need "don't save project" to do, ideally. .


Gale


> On Thu, Feb 2, 2017 at 1:39 PM, Gale Andrews <[hidden email]> wrote:
>>
>> On 31 January 2017 at 22:25, James Crook <[hidden email]> wrote:
>> > Pushed tip of branch bug1567-simple to master.
>> > I chose to include the updated comment, as it is safe and improves
>> > matters.
>> > --James.
>>
>> This works for me. Even if the project you save is not the last, its
>> project folder is removed, and 1567 doesn't occur.
>>
>> This now reduces 1521 (and thus 1567) to the case of close without
>> save on any project except the last (irresepctive of how the project's
>> audio was created).
>>
>>
>>
>> Gale
>>
>>
>> > On 1/31/2017 5:47 PM, Paul Licameli wrote:
>> >> Gale discovered that 6b65375 now causes the temporary projectNNNNN..
>> >> folder
>> >> in SessionData to linger after the new untitled project is saved
>> >> elsewhere.  Lingers until closing of the last project window.
>> >>
>> >> I should have seen that coming.  I have written the correction for
>> >> that.
>> >>
>> >> The fix is at the tip of my branch bug1567-simple, and its id is:
>> >>
>> >>
>> >>
>> >> 5392feefd4c9e0f9952fc2328a303d8f8614f319
>> >>
>> >>
>> >>
>> >> PRL
>> >>
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another commit for master

James Crook
On 2/3/2017 1:31 AM, Gale Andrews wrote:
> I'm talking about HEAD as it appears in jc11.dmg. In other words, even
> without your "1469045", save project now always totally cleans up that
> project in SessionData, leaving no folder at all, even if there are other
> projects open.
>
> That;s what we now need "don't save project" to do, ideally. .

Have I read things correctly that that problem only happens if at some
point you have two projects open at the same time?  Does 1567 now appear
to be only a 'multiproject' bug?

--James.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another commit for master

Gale
Administrator
On 3 February 2017 at 09:28, James Crook <[hidden email]> wrote:

> On 2/3/2017 1:31 AM, Gale Andrews wrote:
>> I'm talking about HEAD as it appears in jc11.dmg. In other words, even
>> without your "1469045", save project now always totally cleans up that
>> project in SessionData, leaving no folder at all, even if there are other
>> projects open.
>>
>> That;s what we now need "don't save project" to do, ideally. .
>
> Have I read things correctly that that problem only happens if at some
> point you have two projects open at the same time?  Does 1567 now appear
> to be only a 'multiproject' bug?

1567 can still occur if you have two or more projects open and you close
any of those projects without saving it.

It does not occur on closing a single project, save or no save, because we
now always remove its project folder in SessionData. It does not occur on
exit and relaunch, even if exiting multiple projects, because on exit we
don't now leave project folders behind in SessionData.

If someone implements a safe way to remove the project folder when we
close a project without saving and other projects are open, I can test if
fork and crash is still needed. But I suspect it will still be needed, because
without it, 1567 occurs merely if you launch, exit and restart Audacity, even
if Session Data is empty.



Gale

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...