Focus on buttons (Re: Small theme issues)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Focus on buttons (Re: Small theme issues)

Paul Licameli


On Fri, Jun 16, 2017 at 1:12 AM, Paul Licameli <[hidden email]> wrote:
1. This should perhaps interest David most.  When you navigate toolbar buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool dock, then TAB key), in Classic and Light themes the focus is very clearly drawn, on Mac and on Windows, as a stippled rectangle.  But note the differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely invisible for Dark and High Contrast themes.

I see there has been a change, but still I see no indication of focus on the Transport toolbar buttons in High Contrast theme on Mac.  Probably relevant, see the conditional compilation in ControlToolBar::MakeButton.  I put it there last year.  How do we change the numbers so that the focus rectangle looks good on Mac in all themes?  Vary the number with the theme?

   enum { deflation =
#ifdef __WXMAC__
      3
#else
      12
#endif
   };
   r->SetFocusRect( r->GetClientRect().Deflate( deflation, deflation ) );

Also on Mac, in either Dark or High Contrast, the focus rings do appear around the drop-down choice controls, but still in a blue color that now constrasts poorly.  But I think this focus ring is not under our easy control.  Recall that I had to hack the wxWidgets 3 source, to interact with the macOS SDK, in order to have any focus at all about thouse buttons.  And I have forgotten the details of what I did now.

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|

Re: Focus on buttons (Re: Small theme issues)

James Crook
I think a thin focus box is useless to someone needing high contrast theme, and we should postpone doing anything about it until 2.2.1.  There is SO much theme tweaking possible, we need to be organised and systematic.

The specific problem is likely that the wide green box of the button matches the dotted green box of the focus and it is drawn on top.  I actually saw the box fine on windows-with-mac-buttons, but maybe the sizing is different on mac.
A possible solution is to make the dotted box dotted text and dotted background colour.  I'm not planning to do that myself.

--James.


On 6/16/2017 5:19 PM, Paul Licameli wrote:
On Fri, Jun 16, 2017 at 1:12 AM, Paul Licameli [hidden email]
wrote:

1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

I see there has been a change, but still I see no indication of focus on
the Transport toolbar buttons in High Contrast theme on Mac.  Probably
relevant, see the conditional compilation in ControlToolBar::MakeButton.  I
put it there last year.  How do we change the numbers so that the focus
rectangle looks good on Mac in all themes?  Vary the number with the theme?

   enum { deflation =
#ifdef __WXMAC__
      3
#else
      12
#endif
   };
   r->SetFocusRect( r->GetClientRect().Deflate( deflation, deflation ) );

Also on Mac, in either Dark or High Contrast, the focus rings do appear
around the drop-down choice controls, but still in a blue color that now
constrasts poorly.  But I think this focus ring is not under our easy
control.  Recall that I had to hack the wxWidgets 3 source, to interact
with the macOS SDK, in order to have any focus at all about thouse
buttons.  And I have forgotten the details of what I did now.

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|

Re: Focus on buttons (Re: Small theme issues)

Paul Licameli
You know what?  Just change 3 to 6 in the code I quoted below, and focus in Transport looks just fine on Mac in all themes.

PRL


On Fri, Jun 16, 2017 at 12:52 PM, James Crook <[hidden email]> wrote:
I think a thin focus box is useless to someone needing high contrast theme, and we should postpone doing anything about it until 2.2.1.  There is SO much theme tweaking possible, we need to be organised and systematic.

The specific problem is likely that the wide green box of the button matches the dotted green box of the focus and it is drawn on top.  I actually saw the box fine on windows-with-mac-buttons, but maybe the sizing is different on mac.
A possible solution is to make the dotted box dotted text and dotted background colour.  I'm not planning to do that myself.

--James.



On 6/16/2017 5:19 PM, Paul Licameli wrote:
On Fri, Jun 16, 2017 at 1:12 AM, Paul Licameli [hidden email]
wrote:

1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

I see there has been a change, but still I see no indication of focus on
the Transport toolbar buttons in High Contrast theme on Mac.  Probably
relevant, see the conditional compilation in ControlToolBar::MakeButton.  I
put it there last year.  How do we change the numbers so that the focus
rectangle looks good on Mac in all themes?  Vary the number with the theme?

   enum { deflation =
#ifdef __WXMAC__
      3
#else
      12
#endif
   };
   r->SetFocusRect( r->GetClientRect().Deflate( deflation, deflation ) );

Also on Mac, in either Dark or High Contrast, the focus rings do appear
around the drop-down choice controls, but still in a blue color that now
constrasts poorly.  But I think this focus ring is not under our easy
control.  Recall that I had to hack the wxWidgets 3 source, to interact
with the macOS SDK, in order to have any focus at all about thouse
buttons.  And I have forgotten the details of what I did now.

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|

Re: Focus on buttons (Re: Small theme issues)

James Crook
On 6/16/2017 6:03 PM, Paul Licameli wrote:
You know what?  Just change 3 to 6 in the code I quoted below, and focus in
Transport looks just fine on Mac in all themes.
Sounds good.  Seems perfectly good solution, so we may as well have it.


PRL


On Fri, Jun 16, 2017 at 12:52 PM, James Crook [hidden email] wrote:

I think a thin focus box is useless to someone needing high contrast
theme, and we should postpone doing anything about it until 2.2.1.  There
is SO much theme tweaking possible, we need to be organised and systematic.

The specific problem is likely that the wide green box of the button
matches the dotted green box of the focus and it is drawn on top.  I
actually saw the box fine on windows-with-mac-buttons, but maybe the sizing
is different on mac.
A possible solution is to make the dotted box dotted text and dotted
background colour.  I'm not planning to do that myself.

--James.



On 6/16/2017 5:19 PM, Paul Licameli wrote:

On Fri, Jun 16, 2017 at 1:12 AM, Paul Licameli [hidden email] [hidden email]
wrote:


1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.


I see there has been a change, but still I see no indication of focus on
the Transport toolbar buttons in High Contrast theme on Mac.  Probably
relevant, see the conditional compilation in ControlToolBar::MakeButton.  I
put it there last year.  How do we change the numbers so that the focus
rectangle looks good on Mac in all themes?  Vary the number with the theme?

   enum { deflation =
#ifdef __WXMAC__
      3
#else
      12
#endif
   };
   r->SetFocusRect( r->GetClientRect().Deflate( deflation, deflation ) );

Also on Mac, in either Dark or High Contrast, the focus rings do appear
around the drop-down choice controls, but still in a blue color that now
constrasts poorly.  But I think this focus ring is not under our easy
control.  Recall that I had to hack the wxWidgets 3 source, to interact
with the macOS SDK, in order to have any focus at all about thouse
buttons.  And I have forgotten the details of what I did now.

PRL




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Audacity-quality mailing [hidden email]



------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



      

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality