Latest "Themes" 05Apr17

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Latest "Themes" 05Apr17

Peter Sampson-2
Testing on W10 audacity-win-rfa62d80-2.2.0-alpha-05-apr-17

Consolidated reporting this time ;-)

1) I have metering, input and output working again - but only if I don;t change theme
If I change theme I need to restart to get metering back.

2) Good to see the numbering back on the meters (I thought, James, from your commit
comment hat you were removing it in the Dark theme - or is that only in DA?)

3) the buttons appear to switch properly now immediately on changing theme - this was
not always the case in yesterday's build (previously unreported)

4) The dark theme now backfills the unused tooldock space with dark.  Both he light thems
backfill with light.

5) The reticules on the two light themes are far too light and faint to be readily seen
cf. 2.1.3 where they are much darker in traditional "Classic".  The light reticules look
fine in the Dark theme.

6) The slider conrtols still all look truncated on the left in both light themes - soddly
thy look ok in Dark theme.  :-//

7) In Dark theme the Scrub Ruler (on by default) is very hard to visually distinguish, which
could lead to folk accidentally straying into it and inadvertently invoking an unwanted Scrub.

8) Waveforms are not rendered in the correct theme colors still when changing themes.

9) When you change from Dark to either of the two light themes (with a track in place) the
padding ad the lft of the waveform scrollbar is padded with dark - and vice versa
when switching from either light them to Dark.

10) In Light theme the TCP controls remain far too dark - too much contrast with the rest
of the TCP in that theme.  Loks fine to me in Classic and Dark.

11) Apart from the truncated slider controls and the light coloured reticule in the sliders
the Classic theme looks pretty much like 2.1.3.

Nice work so far - I'm liking this a lot

Peter.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Latest "Themes" 05Apr17

Peter Sampson-2
Testing on W10 audacity-win-r715da2b-2.2.0-alpha-06-apr-17

On Wed, Apr 5, 2017 at 5:59 PM, James Crook <[hidden email]> wrote:
On 4/5/2017 2:35 PM, Peter Sampson wrote:
Testing on W10 audacity-win-rfa62d80-2.2.0-alpha-05-apr-17

Consolidated reporting this time ;-)
Thanks.  That helps.  And way better than raising bugs for these.


1) I have metering, input and output working again - but only if I don't
change theme. If I change theme I need to restart to get metering back.
Fixed.  It was much harder to find out what was going wrong than it looks from the commit.

With audacity-win-r715da2b-2.2.0-alpha-06-apr-17 it looks like I can change theme and still
get metering.  Any ongoing montoring is stopped and changinging theme, but can  readily
be restarted in the new theme.
 

2) Good to see the numbering back on the meters (I thought, James, from
your commit comment hat you were removing it in the Dark theme - or is that only in DA?)
If you compile with EXPERIMENTAL_DA you get DA.  If you compile without EXPERIMENTAL_DA you get Audacity.  More and more I am converting the differences into options so that these become differences in default choices of the options.



3) the buttons appear to switch properly now immediately on changing theme
- this was not always the case in yesterday's build (previously unreported)

4) The dark theme now backfills the unused tooldock space with dark.  Both
the light theme backfill with light.

5) The reticules on the two light themes are far too light and faint to be
readily seen cf. 2.1.3 where they are much darker in traditional "Classic".  The light
reticules look fine in the Dark theme.
What do you mean by reticules?  Do you mean lines round the mute/solo buttons?
[Later] Ah, you're talking about the sliders.  Yes.  Sliders are not behaving correctly.

The reticules (little marks on the sliders) are stii too liight-coloured for both the Classic
abd the Light theme.  They are darker in 2.1.3
 

6) The slider conrtols still all look truncated on the left in both light
themes - sadly.   they look ok in Dark theme.  :-//
Yep.  Work to do there.

These look ok on audacity-win-r715da2b-2.2.0-alpha-06-apr-17

I note that Classic has the old style (same as 2.1.3) but you have changed the slider
controls for Dark & Light themes - totally happy with that.

Not you issue, James, but you might like to take a look at it while you are working
on the sliders - the tooltips for the sloder controls display with different boxing
 

7) In Dark theme the Scrub Ruler (on by default) is very hard to visually
distinguish, which
could lead to folk accidentally straying into it and inadvertently invoking
an unwanted Scrub.
I'll think on it.

Still hard to distinguish in Dark theme - ok in both other themes.
 

8) Waveforms are not rendered in the correct theme colors still when
changing themes.
They are for me.  Please check.

9) When you change from Dark to either of the two light themes (with a
track in place) the padding ad the lft of the waveform scrollbar is padded with dark - and vice versa when switching from either light them to Dark.
Always padded with light for me.  Please check.
 
audacity-win-r715da2b-2.2.0-alpha-06-apr-17

Yepper, always padde with light.
 


10) In Light theme the TCP controls remain far too dark - too much contrast
with the rest of the TCP in that theme.  Loks fine to me in Classic and Dark.
Totally agree they are too dark.
10a) On all themes still need to do button colour adjustment for selected/unselected.

audacity-win-r715da2b-2.2.0-alpha-06-apr-17

Looks much better on Light theme now - and fine in the other two themes
 

11) Apart from the truncated slider controls and the light coloured
reticule in the sliders the Classic theme looks pretty much like 2.1.3.
Yep.  Sliders need work.

audacity-win-r715da2b-2.2.0-alpha-06-apr-17

The unoccupied background in he waveform pane in Classic theme is stiil much
ligher than we have in 2.1.3 (as Gale observed earlier).   A very noticeable
difference between 2.1.3 and Classic theme.

 




Nice work so far - I'm liking this a lot

And looking better every day, getting very close now   :-))

Peter.
 

Peter.




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Latest "Themes" 05Apr17

James Crook
In reply to this post by Peter Sampson-2


On 4/6/2017 1:14 PM, Peter Sampson wrote:

> On Thu, Apr 6, 2017 at 12:52 PM, James Crook <[hidden email]> wrote:
>
>> And now no longer confirmed...
>> I think I had my microphone volume set to zero.
>>
>> Could you check again?
> Ooh yes, upping the mic slider helps a lot. <blushes deeply>
>
> Sorry for the "noise".
>
>
>> Previously any change to preferences (not just Meter dB range) would
>> prevent metering of monitoring.  I believe I fixed that yesterday about
>> 5:30, and that that fix should be in yesterday's nightly.
> Confirmed - testing on W10 audacity-win-r715da2b-2.2.0-alpha-06-apr-17
>
> Also it looks like I can now swap themes and still get metering.
Yes.

> I do have to restart the ongoing monitoring after I have changed theme -
> but I'm guessing that may be intended behaviour.
There is/was code already in there that stops monitoring on clicking OK,
in case the device has been changed in changing preferences. Preferences
could be a bit smarter and only do that if the device (or some other
relevant parameter) actually has been changed.


>
>> By the way, the problem was not my fault.  The problem would have happened
>> without my theming changes.
> hahaha - we don't work in a "blame culture" anyway ... ;-))
>
> Peter
True, and it is good that we don't have a blame culture.  I was just
feeling a bit vulnerable/anxious as I am aware I checked in the
theming/switching code a bit sooner than I/we normally would.






>
>
>> --James.
>>
>>
>>
>> On 4/5/2017 11:39 PM, James Crook wrote:
>>
>>> On 4/5/2017 11:00 PM, Peter Sampson wrote:
>>>
>>>> 10) Just discovered that if I change the Meter dB Range in Interface
>>>> Prefs
>>>> then I lose metering until I close and restart Audacity.
>>>>
>>>> This happens in today's and yesterday's nightlies and is a regression on
>>>> 2.1.3.
>>>>
>>>> Peter.
>>>>
>>>> Thanks Peter.  Confirmed.  The 'meters not working' code is a little
>>> tricky to track down as it is in code I didn't change. I'll have a deeper
>>> look tomorrow.
>>>
>>> --James.
>>>
>>>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Latest "Themes" 05Apr17

Peter Sampson-2
Hi James,

additional items:

12) With Classic theme I spotted another variance fro 2.1.3

With nothing selected the TCP control butttons take the light colour of the
TCP backgrounfd - selecting in the audaio track darkens the TCP background
but the buttons remain the same light colour.

Whereas in 2.1.3 when the TCP background darkened the bottons and trackname
darkened too.

This also happens in Dark and Light, but the contrast there is not as stark so for
these two theme the non-changing buttons look ok without changing on
selection and deaselection.


13)  I thought you were going to change the theme selection to a more compact
dropdown menu selection rather than radio buttons. 

This will become even more important is we add more themes later.

Cheers, Peter.



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Latest "Themes" 05Apr17

James Crook
In reply to this post by Peter Sampson-2
Re the 'To:' - I subscribe to -quality so I am getting two copies of
these emails.  Please choose one or other address.  (two copies also
causes me confusion when I reply).


On 4/6/2017 1:45 PM, Peter Sampson wrote:
> The reticules (little marks on the sliders) are stii too
> liight-coloured for both the Classic abd the Light theme. They are
> darker in 2.1.3
The reticules in 2.1.3 have two colours (3D look) and I will reintroduce
that.

However I don't want them for the dark theme or for DA - they are
unhelpful/distracting embelishment IMO and I'm only putting them back
there for classic to avoid 'a regression' on classic theme.  I will use
a trick with colours to make it optional, e.g using the background
colour for both light and dark ticks means no ticks - so dark theme can
continue to not have them and still use the same code.

>
>> 6) The slider conrtols still all look truncated on the left in both light themes - sadly.   they look ok in Dark theme.  :-//
> These look ok on audacity-win-r715da2b-2.2.0-alpha-06-apr-17
>
> I note that Classic has the old style (same as 2.1.3) but you have changed
> the slider controls for Dark & Light themes - totally happy with that.
Also the pip isn't rotated for Mixer Board - will fix.  Mixer board
needs a restart to adopt the new theme - might fix.  Multiproject
wormcan needs restart to adopt new theme - maybe-won't-fix.


> Not you issue, James, but you might like to take a look at it while you are
> working on the sliders - the tooltips for the sloder controls display with
> different boxing compared to all other tooltips see:
> http://bugzilla.audacityteam.org/show_bug.cgi?id=1433
Not treating that as part of theming.

>
>> 7) In Dark theme the Scrub Ruler (on by default) is very hard to visually distinguish
> Still hard to distinguish in Dark theme - ok in both other themes.
Yes.  It's unchanged.  I'll get to it in time.


> audacity-win-r715da2b-2.2.0-alpha-06-apr-17
>
> The unoccupied background in the waveform pane in Classic theme is stiil much
> ligher than we have in 2.1.3 (as Gale observed earlier).   A very noticeable
> difference between 2.1.3 and Classic theme.
I can tone that down back to where it was.

I inadvertently used a colour from the light theme, and 'fixed' the
buttons to match, rather than fixing that colour to match the buttons.





--James.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Latest "Themes" 05Apr17

James Crook
In reply to this post by Peter Sampson-2
On 4/6/2017 2:14 PM, Peter Sampson wrote:

> Hi James,
>
> additional items:
>
> 12) With Classic theme I spotted another variance fro 2.1.3
>
> With nothing selected the TCP control butttons take the light colour of the
> TCP backgrounfd - selecting in the audaio track darkens the TCP background
> but the buttons remain the same light colour.
>
> Whereas in 2.1.3 when the TCP background darkened the bottons and trackname
> darkened too.
>
> This also happens in Dark and Light, but the contrast there is not as stark
> so for
> these two theme the non-changing buttons look ok without changing on
> selection and deaselection.

Yes.  I'm aware of that and had already commented on it.
Additionally the down Mute/Solo buttons do not have the 'bluey-grey'
highlight (or is that a lowlight :-) ?)

> 13)  I thought you were going to change the theme selection to a more
> compact dropdown menu selection rather than radio buttons.
>
> This will become even more important is we add more themes later.
Tracking down the lost-meters took most of the time I had available for
work on the code yesterday.
It IS on my list.



>
> Cheers, Peter.
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Loading...