Mac build failure

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Mac build failure

Stevethefiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.

Attached is a build log for a release build of commit f725e937a45c2f

Steve

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

buildlog.txt (5M) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Mac build failure

Henric Jungheim

Here's the bit of the buildlog that jumps out at me:

On Wed, Jul 19, 2017 at 10:52:11PM +0100, Steve the Fiddle wrote:
> I'm still not able to build on Mac after commit ef9745b93
> Consequently I've been able to make no progress with the Mac nightlies.
>
> Attached is a build log for a release build of commit f725e937a45c2f
>
> Steve

...

CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
    cd /Users/steve/Documents/sourcecode/Audacity/mac
    export LANG=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules -Wno-trigraphs -
fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1 -DAUDACITY_DLL_API= -
isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks -I../src/widgets -I../src/xml -I../src/effects/audiounits -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
../src/tracks/playabletrack -I../src/tracks/timetrack -I../src/tracks/ui -I../src/tracks/labeltrack/ui -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui -I../src/tracks/pl
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad -I../lib-src/libogg/include -I../lib-src/libn
yquist/nyq -I../mac/config/i386/lib-src/libsndfile -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch -I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386 -I/Users/steve/Documents/
sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
In file included from /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
In file included from /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error: control reaches end of non-void function [-Werror,-Wreturn-type]
    bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
                                                                            ^
1 error generated.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Mac build failure

Stevethefiddle
On 20 July 2017 at 10:41, Henric Jungheim <[hidden email]> wrote:

>
> Here's the bit of the buildlog that jumps out at me:
>
> On Wed, Jul 19, 2017 at 10:52:11PM +0100, Steve the Fiddle wrote:
>> I'm still not able to build on Mac after commit ef9745b93
>> Consequently I've been able to make no progress with the Mac nightlies.
>>
>> Attached is a build log for a release build of commit f725e937a45c2f
>>
>> Steve
>
> ...
>
> CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>     cd /Users/steve/Documents/sourcecode/Audacity/mac
>     export LANG=en_US.US-ASCII
>     /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules -Wno-trigraphs -
> fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
> s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -
> Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1 -DAUDACITY_DLL_API= -
> isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
> onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
> /src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks -I../src/widgets -I../src/xml -I../src/effects/audiounits -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
> ../src/tracks/playabletrack -I../src/tracks/timetrack -I../src/tracks/ui -I../src/tracks/labeltrack/ui -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui -I../src/tracks/pl
> ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad -I../lib-src/libogg/include -I../lib-src/libn
> yquist/nyq -I../mac/config/i386/lib-src/libsndfile -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
> mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch -I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
> /lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386 -I/Users/steve/Documents/
> sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
> -DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
> edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
> acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
> e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
> In file included from /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
> In file included from /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error: control reaches end of non-void function [-Werror,-Wreturn-type]
>     bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
>                                                                             ^
> 1 error generated.


Thanks Henric,

Yes I can see there's an error in
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h

bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }

There's no bool return value.

Which seems to come from this commit:
https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124

Steve

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Mac build failure

Stevethefiddle
On 20 July 2017 at 11:27, Steve the Fiddle <[hidden email]> wrote:

> On 20 July 2017 at 10:41, Henric Jungheim <[hidden email]> wrote:
>>
>> Here's the bit of the buildlog that jumps out at me:
>>
>> On Wed, Jul 19, 2017 at 10:52:11PM +0100, Steve the Fiddle wrote:
>>> I'm still not able to build on Mac after commit ef9745b93
>>> Consequently I've been able to make no progress with the Mac nightlies.
>>>
>>> Attached is a build log for a release build of commit f725e937a45c2f
>>>
>>> Steve
>>
>> ...
>>
>> CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>>     cd /Users/steve/Documents/sourcecode/Audacity/mac
>>     export LANG=en_US.US-ASCII
>>     /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules -Wno-trigraphs -
>> fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
>> s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -
>> Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1 -DAUDACITY_DLL_API= -
>> isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
>> onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
>> /src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks -I../src/widgets -I../src/xml -I../src/effects/audiounits -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
>> ../src/tracks/playabletrack -I../src/tracks/timetrack -I../src/tracks/ui -I../src/tracks/labeltrack/ui -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui -I../src/tracks/pl
>> ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad -I../lib-src/libogg/include -I../lib-src/libn
>> yquist/nyq -I../mac/config/i386/lib-src/libsndfile -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
>> mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch -I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
>> /lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386 -I/Users/steve/Documents/
>> sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
>> -DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
>> edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
>> acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
>> e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> In file included from /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
>> In file included from /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
>> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error: control reaches end of non-void function [-Werror,-Wreturn-type]
>>     bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
>>                                                                             ^
>> 1 error generated.
>
>
> Thanks Henric,
>
> Yes I can see there's an error in
> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
>
> bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
>
> There's no bool return value.
>
> Which seems to come from this commit:
> https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124

Which I see Paul told us about at the beginning of July
http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-headers-for-Mac-td7581188.html

Any reason why this wasn't fixed?

Steve

>
> Steve

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Mac build failure

Paul Licameli
There is nothing to be fixed now in the source tree.  As described there, it should work if you do all the instructions to build Mac from nothing, including the wxWidgets build and install with modifications.  But if you did not repeat that, then as the email says, you can make a small edit in /usr/include and continue.

PRL


On Thursday, July 20, 2017, Steve the Fiddle <[hidden email]> wrote:
On 20 July 2017 at 11:27, Steve the Fiddle <<a href="javascript:;" onclick="_e(event, &#39;cvml&#39;, &#39;stevethefiddle@gmail.com&#39;)">stevethefiddle@...> wrote:
> On 20 July 2017 at 10:41, Henric Jungheim <<a href="javascript:;" onclick="_e(event, &#39;cvml&#39;, &#39;software@henric.org&#39;)">software@...> wrote:
>>
>> Here's the bit of the buildlog that jumps out at me:
>>
>> On Wed, Jul 19, 2017 at 10:52:11PM +0100, Steve the Fiddle wrote:
>>> I'm still not able to build on Mac after commit ef9745b93
>>> Consequently I've been able to make no progress with the Mac nightlies.
>>>
>>> Attached is a build log for a release build of commit f725e937a45c2f
>>>
>>> Steve
>>
>> ...
>>
>> CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>>     cd /Users/steve/Documents/sourcecode/Audacity/mac
>>     export LANG=en_US.US-ASCII
>>     /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules -Wno-trigraphs -
>> fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
>> s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -
>> Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1 -DAUDACITY_DLL_API= -
>> isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
>> onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
>> /src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks -I../src/widgets -I../src/xml -I../src/effects/audiounits -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
>> ../src/tracks/playabletrack -I../src/tracks/timetrack -I../src/tracks/ui -I../src/tracks/labeltrack/ui -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui -I../src/tracks/pl
>> ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad -I../lib-src/libogg/include -I../lib-src/libn
>> yquist/nyq -I../mac/config/i386/lib-src/libsndfile -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
>> mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch -I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
>> /lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386 -I/Users/steve/Documents/
>> sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
>> -DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
>> edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
>> acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
>> e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> In file included from /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
>> In file included from /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
>> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error: control reaches end of non-void function [-Werror,-Wreturn-type]
>>     bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
>>                                                                             ^
>> 1 error generated.
>
>
> Thanks Henric,
>
> Yes I can see there's an error in
> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
>
> bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
>
> There's no bool return value.
>
> Which seems to come from this commit:
> https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124

Which I see Paul told us about at the beginning of July
http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-headers-for-Mac-td7581188.html

Any reason why this wasn't fixed?

Steve

>
> Steve

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
<a href="javascript:;" onclick="_e(event, &#39;cvml&#39;, &#39;audacity-devel@lists.sourceforge.net&#39;)">audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Mac build failure

Stevethefiddle
On 20 July 2017 at 12:37, Paul Licameli <[hidden email]> wrote:
> There is nothing to be fixed now in the source tree.  As described there, it
> should work if you do all the instructions to build Mac from nothing,

I did, and it doesn't.

If you follow the instructions in Build.txt to the letter, the build fails.

Here are the instructions:
https://github.com/audacity/audacity/blob/master/mac/Build.txt

Here is the patched wxWidgets that it tells you to download:
https://github.com/audacity/wxWidgets/tree/audacity-fixes

And here is the file with your bug:
https://github.com/audacity/wxWidgets/blob/audacity-fixes/include/wx/osx/cocoa/private.h
which is clearly NOT fixed because here is the error:
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }

Steve


> including the wxWidgets build and install with modifications.  But if you
> did not repeat that, then as the email says, you can make a small edit in
> /usr/include and continue.
>
> PRL
>
>
> On Thursday, July 20, 2017, Steve the Fiddle <[hidden email]>
> wrote:
>>
>> On 20 July 2017 at 11:27, Steve the Fiddle <[hidden email]>
>> wrote:
>> > On 20 July 2017 at 10:41, Henric Jungheim <[hidden email]> wrote:
>> >>
>> >> Here's the bit of the buildlog that jumps out at me:
>> >>
>> >> On Wed, Jul 19, 2017 at 10:52:11PM +0100, Steve the Fiddle wrote:
>> >>> I'm still not able to build on Mac after commit ef9745b93
>> >>> Consequently I've been able to make no progress with the Mac
>> >>> nightlies.
>> >>>
>> >>> Attached is a build log for a release build of commit f725e937a45c2f
>> >>>
>> >>> Steve
>> >>
>> >> ...
>> >>
>> >> CompileC
>> >> build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
>> >> normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>> >>     cd /Users/steve/Documents/sourcecode/Audacity/mac
>> >>     export LANG=en_US.US-ASCII
>> >>
>> >> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
>> >> -x objective-c++ -arch i386 -fmessage-length=0
>> >> -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11
>> >> -stdlib=libstdc++ -gmodules -Wno-trigraphs -
>> >> fpascal-strings -O3 -Wno-missing-field-initializers
>> >> -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties
>> >> -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual
>> >> -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
>> >> s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter
>> >> -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized
>> >> -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion
>> >> -Wno-constant-conversion -Wno-int-conversion -
>> >> Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32
>> >> -Wno-newline-eof -Wno-selector -Wno-strict-selector-match
>> >> -Wno-undeclared-selector -Wno-deprecated-implementations
>> >> -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1
>> >> -DAUDACITY_DLL_API= -
>> >> isysroot
>> >> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
>> >> -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations
>> >> -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden
>> >> -Wno-sign-c
>> >> onversion
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap
>> >> -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile
>> >> -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
>> >> /src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks
>> >> -I../src/widgets -I../src/xml -I../src/effects/audiounits
>> >> -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist
>> >> -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
>> >> ../src/tracks/playabletrack -I../src/tracks/timetrack
>> >> -I../src/tracks/ui -I../src/tracks/labeltrack/ui
>> >> -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui
>> >> -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui
>> >> -I../src/tracks/pl
>> >> ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui
>> >> -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag
>> >> -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad
>> >> -I../lib-src/libogg/include -I../lib-src/libn
>> >> yquist/nyq -I../mac/config/i386/lib-src/libsndfile
>> >> -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src
>> >> -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include
>> >> -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
>> >> mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch
>> >> -I../mac/config/i386/lib-src/soundtouch/include
>> >> -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv
>> >> -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
>> >> /lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386
>> >> -I/Users/steve/Documents/
>> >>
>> >> sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources
>> >> -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release
>> >> -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release
>> >> -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
>> >> -DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__
>> >> -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include
>> >> /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
>> >> edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF
>> >> /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d
>> >> --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
>> >>
>> >> acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia
>> >> -c
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
>> >> -o
>> >> /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
>> >> e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> >> In file included from
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
>> >> In file included from
>> >> /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
>> >> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error:
>> >> control reaches end of non-void function [-Werror,-Wreturn-type]
>> >>     bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen =
>> >> fullScreen; }
>> >>
>> >> ^
>> >> 1 error generated.
>> >
>> >
>> > Thanks Henric,
>> >
>> > Yes I can see there's an error in
>> > /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
>> >
>> > bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
>> >
>> > There's no bool return value.
>> >
>> > Which seems to come from this commit:
>> >
>> > https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124
>>
>> Which I see Paul told us about at the beginning of July
>>
>> http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-headers-for-Mac-td7581188.html
>>
>> Any reason why this wasn't fixed?
>>
>> Steve
>>
>> >
>> > Steve
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Mac build failure

Paul Licameli


On Thu, Jul 20, 2017 at 7:47 AM, Steve the Fiddle <[hidden email]> wrote:
On 20 July 2017 at 12:37, Paul Licameli <[hidden email]> wrote:
> There is nothing to be fixed now in the source tree.  As described there, it
> should work if you do all the instructions to build Mac from nothing,

I did, and it doesn't.

If you follow the instructions in Build.txt to the letter, the build fails.

Here are the instructions:
https://github.com/audacity/audacity/blob/master/mac/Build.txt

Here is the patched wxWidgets that it tells you to download:
https://github.com/audacity/wxWidgets/tree/audacity-fixes

And here is the file with your bug:
https://github.com/audacity/wxWidgets/blob/audacity-fixes/include/wx/osx/cocoa/private.h
which is clearly NOT fixed because here is the error:
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }

Steve

I see, you didn't do this procedure, which is what I did for my own build:  http://wiki.audacityteam.org/wiki/Building_On_Mac#Using_wxWidgets_from_wxWidgets

Instead you follow the newer procedure of just getting our modified wxWidgets source tree from GitHub.

I updated the patch files, which are part of Audacity's own source tree.

But I did not update our branch at the wxWidgets repository, to support this newer way of doing it.

I will fix that at once.

PRL

 


> including the wxWidgets build and install with modifications.  But if you
> did not repeat that, then as the email says, you can make a small edit in
> /usr/include and continue.
>
> PRL
>
>
> On Thursday, July 20, 2017, Steve the Fiddle <[hidden email]>
> wrote:
>>
>> On 20 July 2017 at 11:27, Steve the Fiddle <[hidden email]>
>> wrote:
>> > On 20 July 2017 at 10:41, Henric Jungheim <[hidden email]> wrote:
>> >>
>> >> Here's the bit of the buildlog that jumps out at me:
>> >>
>> >> On Wed, Jul 19, 2017 at 10:52:11PM +0100, Steve the Fiddle wrote:
>> >>> I'm still not able to build on Mac after commit ef9745b93
>> >>> Consequently I've been able to make no progress with the Mac
>> >>> nightlies.
>> >>>
>> >>> Attached is a build log for a release build of commit f725e937a45c2f
>> >>>
>> >>> Steve
>> >>
>> >> ...
>> >>
>> >> CompileC
>> >> build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
>> >> normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>> >>     cd /Users/steve/Documents/sourcecode/Audacity/mac
>> >>     export LANG=en_US.US-ASCII
>> >>
>> >> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
>> >> -x objective-c++ -arch i386 -fmessage-length=0
>> >> -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11
>> >> -stdlib=libstdc++ -gmodules -Wno-trigraphs -
>> >> fpascal-strings -O3 -Wno-missing-field-initializers
>> >> -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties
>> >> -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual
>> >> -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
>> >> s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter
>> >> -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized
>> >> -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion
>> >> -Wno-constant-conversion -Wno-int-conversion -
>> >> Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32
>> >> -Wno-newline-eof -Wno-selector -Wno-strict-selector-match
>> >> -Wno-undeclared-selector -Wno-deprecated-implementations
>> >> -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1
>> >> -DAUDACITY_DLL_API= -
>> >> isysroot
>> >> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
>> >> -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations
>> >> -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden
>> >> -Wno-sign-c
>> >> onversion
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap
>> >> -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile
>> >> -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
>> >> /src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks
>> >> -I../src/widgets -I../src/xml -I../src/effects/audiounits
>> >> -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist
>> >> -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
>> >> ../src/tracks/playabletrack -I../src/tracks/timetrack
>> >> -I../src/tracks/ui -I../src/tracks/labeltrack/ui
>> >> -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui
>> >> -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui
>> >> -I../src/tracks/pl
>> >> ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui
>> >> -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag
>> >> -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad
>> >> -I../lib-src/libogg/include -I../lib-src/libn
>> >> yquist/nyq -I../mac/config/i386/lib-src/libsndfile
>> >> -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src
>> >> -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include
>> >> -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
>> >> mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch
>> >> -I../mac/config/i386/lib-src/soundtouch/include
>> >> -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv
>> >> -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
>> >> /lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386
>> >> -I/Users/steve/Documents/
>> >>
>> >> sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources
>> >> -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release
>> >> -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release
>> >> -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
>> >> -DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__
>> >> -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include
>> >> /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
>> >> edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF
>> >> /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d
>> >> --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
>> >>
>> >> acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia
>> >> -c
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
>> >> -o
>> >> /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
>> >> e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> >> In file included from
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
>> >> In file included from
>> >> /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
>> >> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error:
>> >> control reaches end of non-void function [-Werror,-Wreturn-type]
>> >>     bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen =
>> >> fullScreen; }
>> >>
>> >> ^
>> >> 1 error generated.
>> >
>> >
>> > Thanks Henric,
>> >
>> > Yes I can see there's an error in
>> > /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
>> >
>> > bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
>> >
>> > There's no bool return value.
>> >
>> > Which seems to come from this commit:
>> >
>> > https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124
>>
>> Which I see Paul told us about at the beginning of July
>>
>> http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-headers-for-Mac-td7581188.html
>>
>> Any reason why this wasn't fixed?
>>
>> Steve
>>
>> >
>> > Steve
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Mac build failure

Paul Licameli


On Thu, Jul 20, 2017 at 8:49 AM, Paul Licameli <[hidden email]> wrote:


On Thu, Jul 20, 2017 at 7:47 AM, Steve the Fiddle <[hidden email]> wrote:
On 20 July 2017 at 12:37, Paul Licameli <[hidden email]> wrote:
> There is nothing to be fixed now in the source tree.  As described there, it
> should work if you do all the instructions to build Mac from nothing,

I did, and it doesn't.

If you follow the instructions in Build.txt to the letter, the build fails.

Here are the instructions:
https://github.com/audacity/audacity/blob/master/mac/Build.txt

Here is the patched wxWidgets that it tells you to download:
https://github.com/audacity/wxWidgets/tree/audacity-fixes

And here is the file with your bug:
https://github.com/audacity/wxWidgets/blob/audacity-fixes/include/wx/osx/cocoa/private.h
which is clearly NOT fixed because here is the error:
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }

Steve

I see, you didn't do this procedure, which is what I did for my own build:  http://wiki.audacityteam.org/wiki/Building_On_Mac#Using_wxWidgets_from_wxWidgets

Instead you follow the newer procedure of just getting our modified wxWidgets source tree from GitHub.

I updated the patch files, which are part of Audacity's own source tree.

But I did not update our branch at the wxWidgets repository, to support this newer way of doing it.

I will fix that at once.

PRL


I have updated the branch audacity-fixes.

PRL

 
 


> including the wxWidgets build and install with modifications.  But if you
> did not repeat that, then as the email says, you can make a small edit in
> /usr/include and continue.
>
> PRL
>
>
> On Thursday, July 20, 2017, Steve the Fiddle <[hidden email]>
> wrote:
>>
>> On 20 July 2017 at 11:27, Steve the Fiddle <[hidden email]>
>> wrote:
>> > On 20 July 2017 at 10:41, Henric Jungheim <[hidden email]> wrote:
>> >>
>> >> Here's the bit of the buildlog that jumps out at me:
>> >>
>> >> On Wed, Jul 19, 2017 at 10:52:11PM +0100, Steve the Fiddle wrote:
>> >>> I'm still not able to build on Mac after commit ef9745b93
>> >>> Consequently I've been able to make no progress with the Mac
>> >>> nightlies.
>> >>>
>> >>> Attached is a build log for a release build of commit f725e937a45c2f
>> >>>
>> >>> Steve
>> >>
>> >> ...
>> >>
>> >> CompileC
>> >> build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
>> >> normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>> >>     cd /Users/steve/Documents/sourcecode/Audacity/mac
>> >>     export LANG=en_US.US-ASCII
>> >>
>> >> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
>> >> -x objective-c++ -arch i386 -fmessage-length=0
>> >> -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11
>> >> -stdlib=libstdc++ -gmodules -Wno-trigraphs -
>> >> fpascal-strings -O3 -Wno-missing-field-initializers
>> >> -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties
>> >> -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual
>> >> -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
>> >> s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter
>> >> -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized
>> >> -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion
>> >> -Wno-constant-conversion -Wno-int-conversion -
>> >> Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32
>> >> -Wno-newline-eof -Wno-selector -Wno-strict-selector-match
>> >> -Wno-undeclared-selector -Wno-deprecated-implementations
>> >> -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1
>> >> -DAUDACITY_DLL_API= -
>> >> isysroot
>> >> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
>> >> -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations
>> >> -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden
>> >> -Wno-sign-c
>> >> onversion
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap
>> >> -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile
>> >> -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
>> >> /src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks
>> >> -I../src/widgets -I../src/xml -I../src/effects/audiounits
>> >> -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist
>> >> -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
>> >> ../src/tracks/playabletrack -I../src/tracks/timetrack
>> >> -I../src/tracks/ui -I../src/tracks/labeltrack/ui
>> >> -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui
>> >> -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui
>> >> -I../src/tracks/pl
>> >> ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui
>> >> -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag
>> >> -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad
>> >> -I../lib-src/libogg/include -I../lib-src/libn
>> >> yquist/nyq -I../mac/config/i386/lib-src/libsndfile
>> >> -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src
>> >> -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include
>> >> -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
>> >> mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch
>> >> -I../mac/config/i386/lib-src/soundtouch/include
>> >> -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv
>> >> -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
>> >> /lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include
>> >> -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386
>> >> -I/Users/steve/Documents/
>> >>
>> >> sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources
>> >> -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release
>> >> -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release
>> >> -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
>> >> -DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__
>> >> -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include
>> >> /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
>> >> edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF
>> >> /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d
>> >> --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
>> >>
>> >> acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia
>> >> -c
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
>> >> -o
>> >> /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
>> >> e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
>> >> In file included from
>> >> /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
>> >> In file included from
>> >> /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
>> >> /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error:
>> >> control reaches end of non-void function [-Werror,-Wreturn-type]
>> >>     bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen =
>> >> fullScreen; }
>> >>
>> >> ^
>> >> 1 error generated.
>> >
>> >
>> > Thanks Henric,
>> >
>> > Yes I can see there's an error in
>> > /usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
>> >
>> > bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
>> >
>> > There's no bool return value.
>> >
>> > Which seems to come from this commit:
>> >
>> > https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124
>>
>> Which I see Paul told us about at the beginning of July
>>
>> http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-headers-for-Mac-td7581188.html
>>
>> Any reason why this wasn't fixed?
>>
>> Steve
>>
>> >
>> > Steve
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...