More about one-pixel changes from 2.1.3 in drawing the buttons on TCP

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

More about one-pixel changes from 2.1.3 in drawing the buttons on TCP

Paul Licameli
There are some other things not involving text, for which wxWidgets behavior is probably less variable across platforms.

There is a diagram I made years ago in comments in TrackPanel.cpp, about line 240, attempting to clarify some things which still seem to have caused confusions.

Every track we draw is surrounded by an "inset" area four pixels wide, in which the yellow focus rectangle is drawn (three pixels wide in three different gradations of yellow).

But there is more inside of the "inset" that frames the track: a one-pixel wide "shadow" on the bottom and right sides only; and then, a one-pixel wide "border" on all four sides.

Look closely with Windows magnifier or option+command+ + on Mac to see these things.

Now comparing 2.2.0 with 2.1.3, these are drawing changes in the buttons that I notice, and I ask whether all were intended and are agreed on as good:

In 2.1.3 the close, menu, and Mute buttons invade the border at top and left.  I'm not sure that's bad:  it contributes to the illusion that the buttons are slightly raised.  But 2.2.0 no longer does this.

In 2.2.0 the Minimize button invades the border below, but not so in 2.1.3.

In 2.2.0 the Menu button extends a bit more rightward than Mute does, and invades the separator between the track control panel and the vertical ruler.

In 2.2.0 the Close, Mute, Solo, Menu, and Minimize buttons are all slightly taller.

PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|

Re: More about one-pixel changes from 2.1.3 in drawing the buttons on TCP

Paul Licameli


On Tue, Jun 6, 2017 at 1:04 PM, Paul Licameli <[hidden email]> wrote:
There are some other things not involving text, for which wxWidgets behavior is probably less variable across platforms.

There is a diagram I made years ago in comments in TrackPanel.cpp, about line 240, attempting to clarify some things which still seem to have caused confusions.

Every track we draw is surrounded by an "inset" area four pixels wide, in which the yellow focus rectangle is drawn (three pixels wide in three different gradations of yellow).

But there is more inside of the "inset" that frames the track: a one-pixel wide "shadow" on the bottom and right sides only; and then, a one-pixel wide "border" on all four sides.

Look closely with Windows magnifier or option+command+ + on Mac to see these things.

Now comparing 2.2.0 with 2.1.3, these are drawing changes in the buttons that I notice, and I ask whether all were intended and are agreed on as good:

In 2.1.3 the close, menu, and Mute buttons invade the border at top and left.  I'm not sure that's bad:  it contributes to the illusion that the buttons are slightly raised.  But 2.2.0 no longer does this.

In 2.2.0 the Minimize button invades the border below, but not so in 2.1.3.

In 2.2.0 the Menu button extends a bit more rightward than Mute does, and invades the separator between the track control panel and the vertical ruler.

In 2.2.0 the Close, Mute, Solo, Menu, and Minimize buttons are all slightly taller.

I also see this is a very old comment in TrackInfo::GetMinimizeRect(), but there is no longer any such space on the left, and I don't know whether that is intended or not:

   // Width is less space on left for track select and on right for sync-lock icon.
 
PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality