Audacity › audacity-devel

[PATCH] Clip Colours

Classic

List

Threaded

4 messages Options

Jeldrik

[PATCH] Clip Colours

...and just more than a half year later -> sorry for the delay.

In april this year I wrote to the list because I wanted to implement the
possibility to choose different colours for your clips. I slowly but
continually worked on that. In the meantime I got a new job and had to
get things properly at the university. Well, there had been some pauses
;-) But finally I did it and I'm able to provide a patch! Yeah!

I would be glad if someone can test the changes and give me feedback
and/or apply the patch.

Best wishes,
Jeldrik

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

clip_colour.patch (22K) Download Attachment

Gale

Re: [PATCH] Clip Colours

Administrator

| From Jeldrik <[hidden email]>
| Mon, 02 Dec 2013 13:49:06 +0100
| Subject: [Audacity-devel] [PATCH] Clip Colours

> ...and just more than a half year later -> sorry for the delay.
>
> In april this year I wrote to the list because I wanted to implement the possibility
> to choose different colours for your clips. I slowly but continually
> worked on that. In the meantime I got a new job and had to get things
> properly at the university. Well, there had been some pauses ;-) But
> finally I did it and I'm able to provide a patch! Yeah!
>
>
> I would be glad if someone can test the changes and give me feedback and/or apply the patch.

Hi Jeldrik

I built the patch on Windows. I didn't find any problems so far.
Well done!

These are just a few usability points.

* The Undo/Redo items have an inconsistent hyphen "Clip-Color".

* The menu item and the colours in the cascading menu list need
access keys (it looks like Clip C&olor is the only viable choice for
the menu item).

* Should the colours in the menu list be greyed out until a clip is
fully selected? It would avoid the temptation to try and colour
a selection.

* What about when "select all... if none" is on in Tracks Preferences,
which is default? As it is now, the colors don't take effect from
the menu if a track without splits has a partial selection or is
selected with no selection in the track, but if the track is deselected
the color can be applied. Perhaps when that Pref. is on, choosing
the colour should always select all and apply the colour in an
unsplit track?

* If I was changing colours a lot I would really want the colour
list accessible by right-click over the clip. I know you can add
shortcuts but there are a lot to remember.

Gale

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

MartynShaw

Re: [PATCH] Clip Colours

In reply to this post by Jeldrik

Hi

This is a 'theme' thing, it seems to me (and I didn't try your code,
just read it briefly).

The repetition of
void AudacityProject::OnClipClrOrange()
void AudacityProject::OnClipClrPuce() (not there!)
and so on is not a good sign for this code.

TTFN
Martyn

On 02/12/2013 12:49, Jeldrik wrote:

> ...and just more than a half year later -> sorry for the delay.
>
> In april this year I wrote to the list because I wanted to implement
> the possibility to choose different colours for your clips. I slowly
> but continually worked on that. In the meantime I got a new job and
> had to get things properly at the university. Well, there had been
> some pauses ;-) But finally I did it and I'm able to provide a patch!
> Yeah!
>
>
> I would be glad if someone can test the changes and give me feedback
> and/or apply the patch.
>
> Best wishes,
> Jeldrik
>
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Vaughan Johnson

Re: [PATCH] Clip Colours

Administrator

I agree. That's why methods have parameters. :-)

- V

On 12/3/2013 5:15 PM, Martyn Shaw wrote:

> Hi
>
> This is a 'theme' thing, it seems to me (and I didn't try your code,
> just read it briefly).
>
> The repetition of
> void AudacityProject::OnClipClrOrange()
> void AudacityProject::OnClipClrPuce() (not there!)
> and so on is not a good sign for this code.
>
> TTFN
> Martyn
>
> On 02/12/2013 12:49, Jeldrik wrote:
>> ...and just more than a half year later -> sorry for the delay.
>>
>> In april this year I wrote to the list because I wanted to implement
>> the possibility to choose different colours for your clips. I slowly
>> but continually worked on that. In the meantime I got a new job and
>> had to get things properly at the university. Well, there had been
>> some pauses ;-) But finally I did it and I'm able to provide a patch!
>> Yeah!
>>
>>
>> I would be glad if someone can test the changes and give me feedback
>> and/or apply the patch.
>>
>> Best wishes,
>> Jeldrik
>>
>>
>> ------------------------------------------------------------------------------
>> Rapidly troubleshoot problems before they affect your business. Most IT
>> organizations don't have a clear picture of how application performance
>> affects their revenue. With AppDynamics, you get 100% visibility into your
>> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
>> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
>>
>>
>>
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>
> ------------------------------------------------------------------------------
> Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>