Re: description of Mod-Script Pipe additions

[John Martin Goddard]

Hi Dan,

2. Re: description of Mod-Script Pipe additions, and one issue (Dan Horgan)

> Hello Marty, thanks for the work on the commands.

> As far as I know you don't currently have CVS access - that being the
> case it might be easiest if you can create a patch file (or several)
> containing your changes, and then post that to the mailing-list. I'm not
> sure what the simplest way to create patches is on windows and it
> probably depends on your current setup, but this tool: http://winmerge.org/
> looks as though it should be able to do the job.

Hi Dan,
James had mentioned providing temporary CVS access for this check-in, probably assuming I'd have it done sooner that it is, and possibly assuming you might not be available to deal with patches.  I'm perfectly happy to do what you describe below.

> The patch file should contain the differences between your versions of
> the changed files and the current CVS versions, preferably in 'unified
> diff' format.

> If you can provide that, I should be able to check that it works for me
> and commit it provided there are no objections (depending on the state
> of the release schedule, it might be too late anyhow). Since this code is only
> used when the scripting module is loaded, it should not pose any threat
> to general stability.  However if there are new files, then the various
> build systems will probably need updating too.

>From what I have read of the mailing-list, I believe that track linking
> is likely to be disabled in 2.0, because in its current incarnation it
> causes to many bugs. I don't know whether that will affect your work,
> but it's worth bearing in mind.
> To nitpick, 'IsMuted' might be more natural sounding than 'IsMute'.

Agreed, "IsMuted" is also more consistent with "AreMuted" for getting the full track set.



> This all looks like useful stuff. In general I'm still slightly wary
> about proliferation of commands and data formats at this fairly early
> stage of scriptability, but I'm happy to add these with the proviso that
> it won't necessarily be set in stone for all time.

Agreed. But the more users with their own scripts that may be impacted, then the more making changes will be felt...  of course this probably goes without saying...

> It'll need to be checked over carefully in any case, and it's up to
> those more closely involved in the release to decide whether it's too
> late to add this now. But as far as I can tell, none of this ought to
> affect the running of the program when no script module is loaded.

> Once again, thanks for the work (and the feedback), and I hope your
> project is going well.

> Best regards,
> Dan

Thanks a lot, I appreciate that.  The project is going slowly.  I'm swimming in architectural issues for the agent based organization of commands and machine learning.

I have some other things regarding the problem with "Stop" not always working from a remote script.

I believe the problem hinges on whether Audacity is in the foreground or the background (as it must be if a script is running in the foreground).

Stop via script seems to only work when Audacity is in the foreground.

In trying to debug this further, I found a curious call that seemed rather curious.  I had to comment it out to discover the flow of execution, and it seems it may be unnecessary:

In TrackPanel.cpp, line 854:   I noticed the following gets called each timer event:
     p->GetControlToolBar()->OnStop(dummyEvent);

So, I can’t yet verify it, but it appears that different code paths are executed when issuing a STOP command via the script pipe, than it is when stopping from the toolbar, (or space bar).

This is probably not the best time to raise this, and I'll investigate further, probably after the patches/checkin.

Best Regards,
Marty

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[James Crook]

John Martin Goddard wrote:
> Hi Dan,
> James had mentioned providing temporary CVS access for this check-in, probably assuming I'd have it done sooner that it is, and possibly assuming you might not be available to deal with patches.  I'm perfectly happy to do what you describe below.
>  

Hi Marty,

I'm anticipating we will be releasing another beta on 1st January.

If you want your extra scripting commands to be in that, we should aim
to have it in CVS head by 15th Dec so there is a bit of time for it to
be tried out.

As part of getting ready, and as per a previous message, can you discuss
syntax of commands a bit more, perhaps on the wiki?  Also can you send
me a sample of the code you've been writing, so I can see how ready it
is to check in.  Thanks.

--James.

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel