Request a few changes to new Features page

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Request a few changes to new Features page

Paul Licameli


On Thu, Jul 20, 2017 at 2:16 PM, Peter Sampson <[hidden email]> wrote:

Looks very good.  The theme and logo images are exciting!

What I would change:

  • The link at top to release notes is incorrect.  I will get busy filling the page in.  The other link at page bottom is correct.
  • MIDI playback should come right after Theme changes.  It's a short and sweet description of a major change.  Put it just after the "exciting" eye catching logo and theme images.  I want those who don't scroll far down the page to notice it, before the more "boring" wordy pictures of menus.
  • Your RM requests that something brief be said about the Esc key now cancelling all drag actions.  And also very high on the page.
    • Don't just do that to gratify me for one of my very few user-visible projects among all my subtle hidden changes.  I think it is important to start educating users new and old in this simple and uniform user interface convention, and putting it on this page is a start.  I want all new users to learn the habit of simply going to Esc whenever they have a "gah, what's this?  Go away!" reaction to something like a snap line or a vertical ruler zoom box.
    • I hope later versions will make more progress on such conventions, such as right click context menus and more consistent tab, arrow, and scrollwheel actions and we will summarize all that prominently in introductory material.
    • (My changes to snap lines, letting them appear even before button down, do not need mention on this page, but something should be said here http://alphamanual.audacityteam.org/man/Audacity_Selection#boundary-snap-guides also mentioning that the first Esc key press escapes a snap guide without cancelling the drag.)
  • The section on clip moving commands gets too deep into detail.  I would move earlier: "The aim is that they have similar functionality to using the mouse with the shift tool. So Clip left/right is roughly equivalent to clicking in the focused track at the time given by selection start, and dragging one pixel to the left/right."  And I would move all the rest after the list of eight onto some other page.
  • I would rather just strike the sentence "This is particularly useful when recording as previously in these cases Audacity used to silently, with no warning, re-use the space at the buginning of your project, corrupting your recording."  I don't like emphasizing how we used to screw up.  Just describe the new thing positively.
  • Wordings and typos
    • Under extended menus, do we want to spell out the abbreviation VI ?
    • "Many place" should say "places"
    • Remove extra spaces before period after "Audacity Wiki"
  • I only ask, should extra space be given over to old logo and menu images?  Or do they only distract from the important things?

PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Request a few changes to new Features page

Paul Licameli


On Fri, Jul 21, 2017 at 11:52 AM, Paul Licameli <[hidden email]> wrote:


On Thu, Jul 20, 2017 at 2:16 PM, Peter Sampson <[hidden email]> wrote:

Looks very good.  The theme and logo images are exciting!

What I would change:

  • The link at top to release notes is incorrect.  I will get busy filling the page in.  The other link at page bottom is correct.
  • MIDI playback should come right after Theme changes.  It's a short and sweet description of a major change.  Put it just after the "exciting" eye catching logo and theme images.  I want those who don't scroll far down the page to notice it, before the more "boring" wordy pictures of menus.
  • Your RM requests that something brief be said about the Esc key now cancelling all drag actions.  And also very high on the page.
    • Don't just do that to gratify me for one of my very few user-visible projects among all my subtle hidden changes.  I think it is important to start educating users new and old in this simple and uniform user interface convention, and putting it on this page is a start.  I want all new users to learn the habit of simply going to Esc whenever they have a "gah, what's this?  Go away!" reaction to something like a snap line or a vertical ruler zoom box.

You may notice that the particular example of Esc for dragging the zoom box is not new in 2.2.0.  Dragging envelope points in the multi-tool might be a better example of a new one.
 
    • I hope later versions will make more progress on such conventions, such as right click context menus and more consistent tab, arrow, and scrollwheel actions and we will summarize all that prominently in introductory material.
    • (My changes to snap lines, letting them appear even before button down, do not need mention on this page, but something should be said here http://alphamanual.audacityteam.org/man/Audacity_Selection#boundary-snap-guides also mentioning that the first Esc key press escapes a snap guide without cancelling the drag.)

Do mention this last in the Appendix page.

I have read the Appendix now and see no section that needs change.

The question is whether the Appendix is otherwise complete, and whether the division of things between the main page and appendix is best.  There are only 1154 commits since 2.1.3 to review... (What about all that stuff with the screenshot menu?)

I would move the low disk space thing to Appendix -- don't worry about my feelings about getting prominent credit for my work.  But it's an example of something that does not affect most users much of the time, does not require a clue to discovery, and neither has any eye grabbing visuals.  I think the main page for new features should include things that meet some of those criteria.

One intiative of mine not yet mentioned is fixing of envelopes to treat discontinuities more correctly.  Pictures might be made, but I wouldn't bother.  Appendix material.

PRL


  • The section on clip moving commands gets too deep into detail.  I would move earlier: "The aim is that they have similar functionality to using the mouse with the shift tool. So Clip left/right is roughly equivalent to clicking in the focused track at the time given by selection start, and dragging one pixel to the left/right."  And I would move all the rest after the list of eight onto some other page.
  • I would rather just strike the sentence "This is particularly useful when recording as previously in these cases Audacity used to silently, with no warning, re-use the space at the buginning of your project, corrupting your recording."  I don't like emphasizing how we used to screw up.  Just describe the new thing positively.
The disk space thing is almost surely a thing for the appendix, as not happening in the ordinary course of things.  Or do you disagree, that this was a much complained of problem whose resolution we should highlight?
 
  • Wordings and typos
    • Under extended menus, do we want to spell out the abbreviation VI ?
    • "Many place" should say "places"
    • Remove extra spaces before period after "Audacity Wiki"
  • I only ask, should extra space be given over to old logo and menu images?  Or do they only distract from the important things?

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Request a few changes to new Features page

Peter Sampson-2


On Fri, Jul 21, 2017 at 5:54 PM, Paul Licameli <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 11:52 AM, Paul Licameli <[hidden email]> wrote:


On Thu, Jul 20, 2017 at 2:16 PM, Peter Sampson <[hidden email]> wrote:

Looks very good.  The theme and logo images are exciting!

What I would change:

  • The link at top to release notes is incorrect.  I will get busy filling the page in.  The other link at page bottom is correct.
  • MIDI playback should come right after Theme changes.  It's a short and sweet description of a major change.  Put it just after the "exciting" eye catching logo and theme images.  I want those who don't scroll far down the page to notice it, before the more "boring" wordy pictures of menus.
  • Your RM requests that something brief be said about the Esc key now cancelling all drag actions.  And also very high on the page.
    • Don't just do that to gratify me for one of my very few user-visible projects among all my subtle hidden changes.  I think it is important to start educating users new and old in this simple and uniform user interface convention, and putting it on this page is a start.  I want all new users to learn the habit of simply going to Esc whenever they have a "gah, what's this?  Go away!" reaction to something like a snap line or a vertical ruler zoom box.

You may notice that the particular example of Esc for dragging the zoom box is not new in 2.2.0.  Dragging envelope points in the multi-tool might be a better example of a new one.
 
    • I hope later versions will make more progress on such conventions, such as right click context menus and more consistent tab, arrow, and scrollwheel actions and we will summarize all that prominently in introductory material.
    • (My changes to snap lines, letting them appear even before button down, do not need mention on this page, but something should be said here http://alphamanual.audacityteam.org/man/Audacity_Selection#boundary-snap-guides also mentioning that the first Esc key press escapes a snap guide without cancelling the drag.)

Do mention this last in the Appendix page.

I have read the Appendix now and see no section that needs change.

The question is whether the Appendix is otherwise complete, and whether the division of things between the main page and appendix is best.  There are only 1154 commits since 2.1.3 to review... (What about all that stuff with the screenshot menu?)

I would move the low disk space thing to Appendix -- don't worry about my feelings about getting prominent credit for my work.  But it's an example of something that does not affect most users much of the time, does not require a clue to discovery, and neither has any eye grabbing visuals.  I think the main page for new features should include things that meet some of those criteria.


I do *not* want to move the low disk space warning to the appendix.

The main reason for this is that it has long been listed on the Wikipedia page about
Audacity as a major drawback.

Hence I want to draw primary attention to this.

Peter

 

One intiative of mine not yet mentioned is fixing of envelopes to treat discontinuities more correctly.  Pictures might be made, but I wouldn't bother.  Appendix material.

PRL


  • The section on clip moving commands gets too deep into detail.  I would move earlier: "The aim is that they have similar functionality to using the mouse with the shift tool. So Clip left/right is roughly equivalent to clicking in the focused track at the time given by selection start, and dragging one pixel to the left/right."  And I would move all the rest after the list of eight onto some other page.
  • I would rather just strike the sentence "This is particularly useful when recording as previously in these cases Audacity used to silently, with no warning, re-use the space at the buginning of your project, corrupting your recording."  I don't like emphasizing how we used to screw up.  Just describe the new thing positively.
The disk space thing is almost surely a thing for the appendix, as not happening in the ordinary course of things.  Or do you disagree, that this was a much complained of problem whose resolution we should highlight?
 
  • Wordings and typos
    • Under extended menus, do we want to spell out the abbreviation VI ?
    • "Many place" should say "places"
    • Remove extra spaces before period after "Audacity Wiki"
  • I only ask, should extra space be given over to old logo and menu images?  Or do they only distract from the important things?

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Request a few changes to new Features page

James Crook
On 7/21/2017 6:45 PM, Peter Sampson wrote:
> I do *not* want to move the low disk space warning to the appendix.
> The main reason for this is that it has long been listed on the Wikipedia
> page about Audacity as a major drawback.
>
> Hence I want to draw primary attention to this.
+1.
But note that http://bugzilla.audacityteam.org/show_bug.cgi?id=437 (P2)
is still open so we are not yet ready to delete that text from Wikipedia.

--James.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Request a few changes to new Features page

Paul Licameli
In reply to this post by Peter Sampson-2


On Fri, Jul 21, 2017 at 1:45 PM, Peter Sampson <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 5:54 PM, Paul Licameli <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 11:52 AM, Paul Licameli <[hidden email]> wrote:


On Thu, Jul 20, 2017 at 2:16 PM, Peter Sampson <[hidden email]> wrote:

Looks very good.  The theme and logo images are exciting!

What I would change:

  • The link at top to release notes is incorrect.  I will get busy filling the page in.  The other link at page bottom is correct.
  • MIDI playback should come right after Theme changes.  It's a short and sweet description of a major change.  Put it just after the "exciting" eye catching logo and theme images.  I want those who don't scroll far down the page to notice it, before the more "boring" wordy pictures of menus.
  • Your RM requests that something brief be said about the Esc key now cancelling all drag actions.  And also very high on the page.
    • Don't just do that to gratify me for one of my very few user-visible projects among all my subtle hidden changes.  I think it is important to start educating users new and old in this simple and uniform user interface convention, and putting it on this page is a start.  I want all new users to learn the habit of simply going to Esc whenever they have a "gah, what's this?  Go away!" reaction to something like a snap line or a vertical ruler zoom box.

You may notice that the particular example of Esc for dragging the zoom box is not new in 2.2.0.  Dragging envelope points in the multi-tool might be a better example of a new one.
 
    • I hope later versions will make more progress on such conventions, such as right click context menus and more consistent tab, arrow, and scrollwheel actions and we will summarize all that prominently in introductory material.
    • (My changes to snap lines, letting them appear even before button down, do not need mention on this page, but something should be said here http://alphamanual.audacityteam.org/man/Audacity_Selection#boundary-snap-guides also mentioning that the first Esc key press escapes a snap guide without cancelling the drag.)

Do mention this last in the Appendix page.

I have read the Appendix now and see no section that needs change.

The question is whether the Appendix is otherwise complete, and whether the division of things between the main page and appendix is best.  There are only 1154 commits since 2.1.3 to review... (What about all that stuff with the screenshot menu?)

I would move the low disk space thing to Appendix -- don't worry about my feelings about getting prominent credit for my work.  But it's an example of something that does not affect most users much of the time, does not require a clue to discovery, and neither has any eye grabbing visuals.  I think the main page for new features should include things that meet some of those criteria.


I do *not* want to move the low disk space warning to the appendix.

The main reason for this is that it has long been listed on the Wikipedia page about
Audacity as a major drawback.

Hence I want to draw primary attention to this.

Peter

Then I yield.
PRL
 

 

One intiative of mine not yet mentioned is fixing of envelopes to treat discontinuities more correctly.  Pictures might be made, but I wouldn't bother.  Appendix material.

PRL


  • The section on clip moving commands gets too deep into detail.  I would move earlier: "The aim is that they have similar functionality to using the mouse with the shift tool. So Clip left/right is roughly equivalent to clicking in the focused track at the time given by selection start, and dragging one pixel to the left/right."  And I would move all the rest after the list of eight onto some other page.
  • I would rather just strike the sentence "This is particularly useful when recording as previously in these cases Audacity used to silently, with no warning, re-use the space at the buginning of your project, corrupting your recording."  I don't like emphasizing how we used to screw up.  Just describe the new thing positively.
The disk space thing is almost surely a thing for the appendix, as not happening in the ordinary course of things.  Or do you disagree, that this was a much complained of problem whose resolution we should highlight?
 
  • Wordings and typos
    • Under extended menus, do we want to spell out the abbreviation VI ?
    • "Many place" should say "places"
    • Remove extra spaces before period after "Audacity Wiki"
  • I only ask, should extra space be given over to old logo and menu images?  Or do they only distract from the important things?

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Inserting commit info into RevisionIdent.h

Cliff Scott
In reply to this post by Paul Licameli
I tried to insert the commit ID into a Audacity build and the build failed building AboutDialog.cpp.

This is the script I used:

git show -s --format="wxT(\"<ahref=\\\"<a href="https://github.com/audacity/audacity/commit/%H">https://github.com/audacity/audacity/commit/%H\\\">%h</a> of%cd\")" > ./src/RevisionIdent.h

It gave me this:

wxT("<ahref=\"https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\">904ddbf</a> ofFri Jul 21 22:17:30 2017 -0400")


Is there anything wrong with this for the RevisionIdent.h file? I'm guessing there is a formatting error.

Thanks.

Cliff


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Inserting commit info into RevisionIdent.h

Pokechu22-3
I can't tell if this is just an email formatting thing or not, but <ahref="http://example.com" ...>text</a> is not valid HTML; it needs to be <a href="http://example.com" ...>text</a> for it to work (note the space).  Wouldn't expect a compile error for that, though; it'd be more likely to get a runtime one (I don't think it makes sense to parse HTML at compiletime...)

--Poke

On Fri, Jul 21, 2017 at 9:32 PM, Cliff Scott <[hidden email]> wrote:
I tried to insert the commit ID into a Audacity build and the build failed building AboutDialog.cpp.

This is the script I used:

git show -s --format="wxT(\"<ahref=\\\"<a href="https://github.com/audacity/audacity/commit/%H\\\" target="_blank" rel="noreferrer">https://github.com/audacity/audacity/commit/%H\\\">%h</a> of%cd\")" > ./src/RevisionIdent.h

It gave me this:

wxT("<ahref=\"<a href="https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\" target="_blank" rel="noreferrer">https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\">904ddbf</a> ofFri Jul 21 22:17:30 2017 -0400")


Is there anything wrong with this for the RevisionIdent.h file? I'm guessing there is a formatting error.

Thanks.

Cliff


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Inserting commit info into RevisionIdent.h

James Crook
In reply to this post by Cliff Scott
The code to do that changed, so instead run:
Audacity\mac\scripts\get_gitident.sh which has:

> git show -s --format="#define REV_LONG \"%H\"%n#define REV_TIME
> \"%cd\"%n" | tee ../src/RevisionIdent.h
> touch ../src/AboutDialog.cpp

--James




On 7/22/2017 5:32 AM, Cliff Scott wrote:

> I tried to insert the commit ID into a Audacity build and the build failed building AboutDialog.cpp.
>
> This is the script I used:
>
> git show -s --format="wxT(\"<ahref=\\\"<a href="https://github.com/audacity/audacity/commit/%H">https://github.com/audacity/audacity/commit/%H\\\">%h</a> of%cd\")" > ./src/RevisionIdent.h
>
> It gave me this:
>
> wxT("<ahref=\"https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\">904ddbf</a> ofFri Jul 21 22:17:30 2017 -0400")
>
>
> Is there anything wrong with this for the RevisionIdent.h file? I'm guessing there is a formatting error.
>
> Thanks.
>
> Cliff
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Inserting commit info into RevisionIdent.h

Cliff Scott
That would explain the issue, however running this from the Audacity directory gives me "no such file or directory" for both RevisionIdent.h and AboutDialog.cpp. Somehow the path isn't being picked up.

Cliff

> On Jul 22, 2017, at 2:37 AM, James Crook <[hidden email]> wrote:
>
> The code to do that changed, so instead run: Audacity\mac\scripts\get_gitident.sh which has:
>
>> git show -s --format="#define REV_LONG \"%H\"%n#define REV_TIME \"%cd\"%n" | tee ../src/RevisionIdent.h
>> touch ../src/AboutDialog.cpp
>
> --James
>
>
>
>
> On 7/22/2017 5:32 AM, Cliff Scott wrote:
>> I tried to insert the commit ID into a Audacity build and the build failed building AboutDialog.cpp.
>>
>> This is the script I used:
>>
>> git show -s --format="wxT(\"<ahref=\\\"<a href="https://github.com/audacity/audacity/commit/%H">https://github.com/audacity/audacity/commit/%H\\\">%h</a> of%cd\")" > ./src/RevisionIdent.h
>>
>> It gave me this:
>>
>> wxT("<ahref=\"https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\">904ddbf</a> ofFri Jul 21 22:17:30 2017 -0400")
>>
>>
>> Is there anything wrong with this for the RevisionIdent.h file? I'm guessing there is a formatting error.
>>
>> Thanks.
>>
>> Cliff
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Inserting commit info into RevisionIdent.h

Cliff Scott
Never mind about the path. I figured out that it only wants 1 period and not two so it works.

Cliff

> On Jul 22, 2017, at 7:48 AM, Cliff Scott <[hidden email]> wrote:
>
> That would explain the issue, however running this from the Audacity directory gives me "no such file or directory" for both RevisionIdent.h and AboutDialog.cpp. Somehow the path isn't being picked up.
>
> Cliff
>
>> On Jul 22, 2017, at 2:37 AM, James Crook <[hidden email]> wrote:
>>
>> The code to do that changed, so instead run: Audacity\mac\scripts\get_gitident.sh which has:
>>
>>> git show -s --format="#define REV_LONG \"%H\"%n#define REV_TIME \"%cd\"%n" | tee ../src/RevisionIdent.h
>>> touch ../src/AboutDialog.cpp
>>
>> --James
>>
>>
>>
>>
>> On 7/22/2017 5:32 AM, Cliff Scott wrote:
>>> I tried to insert the commit ID into a Audacity build and the build failed building AboutDialog.cpp.
>>>
>>> This is the script I used:
>>>
>>> git show -s --format="wxT(\"<ahref=\\\"<a href="https://github.com/audacity/audacity/commit/%H">https://github.com/audacity/audacity/commit/%H\\\">%h</a> of%cd\")" > ./src/RevisionIdent.h
>>>
>>> It gave me this:
>>>
>>> wxT("<ahref=\"https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\">904ddbf</a> ofFri Jul 21 22:17:30 2017 -0400")
>>>
>>>
>>> Is there anything wrong with this for the RevisionIdent.h file? I'm guessing there is a formatting error.
>>>
>>> Thanks.
>>>
>>> Cliff
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Audacity-quality mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Inserting commit info into RevisionIdent.h

James Crook
On 7/22/2017 1:52 PM, Cliff Scott wrote:
> Never mind about the path. I figured out that it only wants 1 period and not two so it works.
Yes.  Or run .\scripts\get_gitident.sh when you are currently in the
Audacity\mac directory.
--James.

>
> Cliff
>> On Jul 22, 2017, at 7:48 AM, Cliff Scott <[hidden email]> wrote:
>>
>> That would explain the issue, however running this from the Audacity directory gives me "no such file or directory" for both RevisionIdent.h and AboutDialog.cpp. Somehow the path isn't being picked up.
>>
>> Cliff
>>
>>> On Jul 22, 2017, at 2:37 AM, James Crook <[hidden email]> wrote:
>>>
>>> The code to do that changed, so instead run: Audacity\mac\scripts\get_gitident.sh which has:
>>>
>>>> git show -s --format="#define REV_LONG \"%H\"%n#define REV_TIME \"%cd\"%n" | tee ../src/RevisionIdent.h
>>>> touch ../src/AboutDialog.cpp
>>> --James
>>>
>>>
>>>
>>>
>>> On 7/22/2017 5:32 AM, Cliff Scott wrote:
>>>> I tried to insert the commit ID into a Audacity build and the build failed building AboutDialog.cpp.
>>>>
>>>> This is the script I used:
>>>>
>>>> git show -s --format="wxT(\"<ahref=\\\"<a href="https://github.com/audacity/audacity/commit/%H">https://github.com/audacity/audacity/commit/%H\\\">%h</a> of%cd\")" > ./src/RevisionIdent.h
>>>>
>>>> It gave me this:
>>>>
>>>> wxT("<ahref=\"https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\">904ddbf</a> ofFri Jul 21 22:17:30 2017 -0400")
>>>>
>>>>
>>>> Is there anything wrong with this for the RevisionIdent.h file? I'm guessing there is a formatting error.
>>>>
>>>> Thanks.
>>>>
>>>> Cliff
>>>>
>>>>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Inserting commit info into RevisionIdent.h

Cliff Scott

> On Jul 22, 2017, at 8:30 AM, James Crook <[hidden email]> wrote:
>
> On 7/22/2017 1:52 PM, Cliff Scott wrote:
>> Never mind about the path. I figured out that it only wants 1 period and not two so it works.
> Yes.  Or run .\scripts\get_gitident.sh when you are currently in the Audacity\mac directory.

Thanks. Swap the slash directions and it works on the Mac as well.

Cliff

> --James.
>>
>> Cliff
>>> On Jul 22, 2017, at 7:48 AM, Cliff Scott <[hidden email]> wrote:
>>>
>>> That would explain the issue, however running this from the Audacity directory gives me "no such file or directory" for both RevisionIdent.h and AboutDialog.cpp. Somehow the path isn't being picked up.
>>>
>>> Cliff
>>>
>>>> On Jul 22, 2017, at 2:37 AM, James Crook <[hidden email]> wrote:
>>>>
>>>> The code to do that changed, so instead run: Audacity\mac\scripts\get_gitident.sh which has:
>>>>
>>>>> git show -s --format="#define REV_LONG \"%H\"%n#define REV_TIME \"%cd\"%n" | tee ../src/RevisionIdent.h
>>>>> touch ../src/AboutDialog.cpp
>>>> --James
>>>>
>>>>
>>>>
>>>>
>>>> On 7/22/2017 5:32 AM, Cliff Scott wrote:
>>>>> I tried to insert the commit ID into a Audacity build and the build failed building AboutDialog.cpp.
>>>>>
>>>>> This is the script I used:
>>>>>
>>>>> git show -s --format="wxT(\"<ahref=\\\"<a href="https://github.com/audacity/audacity/commit/%H">https://github.com/audacity/audacity/commit/%H\\\">%h</a> of%cd\")" > ./src/RevisionIdent.h
>>>>>
>>>>> It gave me this:
>>>>>
>>>>> wxT("<ahref=\"https://github.com/audacity/audacity/commit/904ddbf2a35cbd839cde9249d9f2e9d2ff9c158d\">904ddbf</a> ofFri Jul 21 22:17:30 2017 -0400")
>>>>>
>>>>>
>>>>> Is there anything wrong with this for the RevisionIdent.h file? I'm guessing there is a formatting error.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> Cliff
>>>>>
>>>>>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Request a few changes to new Features page

Paul Licameli
In reply to this post by Paul Licameli


On Fri, Jul 21, 2017 at 3:59 PM, Paul Licameli <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 1:45 PM, Peter Sampson <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 5:54 PM, Paul Licameli <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 11:52 AM, Paul Licameli <[hidden email]> wrote:


On Thu, Jul 20, 2017 at 2:16 PM, Peter Sampson <[hidden email]> wrote:

Looks very good.  The theme and logo images are exciting!

What I would change:

  • The link at top to release notes is incorrect.  I will get busy filling the page in.  The other link at page bottom is correct.
  • MIDI playback should come right after Theme changes.  It's a short and sweet description of a major change.  Put it just after the "exciting" eye catching logo and theme images.  I want those who don't scroll far down the page to notice it, before the more "boring" wordy pictures of menus.
  • Your RM requests that something brief be said about the Esc key now cancelling all drag actions.  And also very high on the page.
    • Don't just do that to gratify me for one of my very few user-visible projects among all my subtle hidden changes.  I think it is important to start educating users new and old in this simple and uniform user interface convention, and putting it on this page is a start.  I want all new users to learn the habit of simply going to Esc whenever they have a "gah, what's this?  Go away!" reaction to something like a snap line or a vertical ruler zoom box.

You may notice that the particular example of Esc for dragging the zoom box is not new in 2.2.0.  Dragging envelope points in the multi-tool might be a better example of a new one.
 
    • I hope later versions will make more progress on such conventions, such as right click context menus and more consistent tab, arrow, and scrollwheel actions and we will summarize all that prominently in introductory material.
    • (My changes to snap lines, letting them appear even before button down, do not need mention on this page, but something should be said here http://alphamanual.audacityteam.org/man/Audacity_Selection#boundary-snap-guides also mentioning that the first Esc key press escapes a snap guide without cancelling the drag.)

Do mention this last in the Appendix page.

I have read the Appendix now and see no section that needs change.

The question is whether the Appendix is otherwise complete, and whether the division of things between the main page and appendix is best.  There are only 1154 commits since 2.1.3 to review... (What about all that stuff with the screenshot menu?)

I would move the low disk space thing to Appendix -- don't worry about my feelings about getting prominent credit for my work.  But it's an example of something that does not affect most users much of the time, does not require a clue to discovery, and neither has any eye grabbing visuals.  I think the main page for new features should include things that meet some of those criteria.


I do *not* want to move the low disk space warning to the appendix.

The main reason for this is that it has long been listed on the Wikipedia page about
Audacity as a major drawback.

Hence I want to draw primary attention to this.

Peter

Then I yield.
PRL

I do, however, still favor shortening the description as I suggested.  Don't emphasize the bad past behavior of the program.  Also that contains a misspelling, "buginning".
 
 

 

One intiative of mine not yet mentioned is fixing of envelopes to treat discontinuities more correctly.  Pictures might be made, but I wouldn't bother.  Appendix material.

PRL


  • The section on clip moving commands gets too deep into detail.  I would move earlier: "The aim is that they have similar functionality to using the mouse with the shift tool. So Clip left/right is roughly equivalent to clicking in the focused track at the time given by selection start, and dragging one pixel to the left/right."  And I would move all the rest after the list of eight onto some other page.
  • I would rather just strike the sentence "This is particularly useful when recording as previously in these cases Audacity used to silently, with no warning, re-use the space at the buginning of your project, corrupting your recording."  I don't like emphasizing how we used to screw up.  Just describe the new thing positively.
The disk space thing is almost surely a thing for the appendix, as not happening in the ordinary course of things.  Or do you disagree, that this was a much complained of problem whose resolution we should highlight?
 
  • Wordings and typos
    • Under extended menus, do we want to spell out the abbreviation VI ?
    • "Many place" should say "places"
    • Remove extra spaces before period after "Audacity Wiki"
  • I only ask, should extra space be given over to old logo and menu images?  Or do they only distract from the important things?

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Request a few changes to new Features page

Peter Sampson-2


On Sat, Jul 22, 2017 at 3:26 PM, Paul Licameli <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 3:59 PM, Paul Licameli <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 1:45 PM, Peter Sampson <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 5:54 PM, Paul Licameli <[hidden email]> wrote:


On Fri, Jul 21, 2017 at 11:52 AM, Paul Licameli <[hidden email]> wrote:


On Thu, Jul 20, 2017 at 2:16 PM, Peter Sampson <[hidden email]> wrote:

Looks very good.  The theme and logo images are exciting!

What I would change:

  • The link at top to release notes is incorrect.  I will get busy filling the page in.  The other link at page bottom is correct.
  • MIDI playback should come right after Theme changes.  It's a short and sweet description of a major change.  Put it just after the "exciting" eye catching logo and theme images.  I want those who don't scroll far down the page to notice it, before the more "boring" wordy pictures of menus.
  • Your RM requests that something brief be said about the Esc key now cancelling all drag actions.  And also very high on the page.
    • Don't just do that to gratify me for one of my very few user-visible projects among all my subtle hidden changes.  I think it is important to start educating users new and old in this simple and uniform user interface convention, and putting it on this page is a start.  I want all new users to learn the habit of simply going to Esc whenever they have a "gah, what's this?  Go away!" reaction to something like a snap line or a vertical ruler zoom box.

You may notice that the particular example of Esc for dragging the zoom box is not new in 2.2.0.  Dragging envelope points in the multi-tool might be a better example of a new one.
 
    • I hope later versions will make more progress on such conventions, such as right click context menus and more consistent tab, arrow, and scrollwheel actions and we will summarize all that prominently in introductory material.
    • (My changes to snap lines, letting them appear even before button down, do not need mention on this page, but something should be said here http://alphamanual.audacityteam.org/man/Audacity_Selection#boundary-snap-guides also mentioning that the first Esc key press escapes a snap guide without cancelling the drag.)

Do mention this last in the Appendix page.

I have read the Appendix now and see no section that needs change.

The question is whether the Appendix is otherwise complete, and whether the division of things between the main page and appendix is best.  There are only 1154 commits since 2.1.3 to review... (What about all that stuff with the screenshot menu?)

I would move the low disk space thing to Appendix -- don't worry about my feelings about getting prominent credit for my work.  But it's an example of something that does not affect most users much of the time, does not require a clue to discovery, and neither has any eye grabbing visuals.  I think the main page for new features should include things that meet some of those criteria.


I do *not* want to move the low disk space warning to the appendix.

The main reason for this is that it has long been listed on the Wikipedia page about
Audacity as a major drawback.

Hence I want to draw primary attention to this.

Peter

Then I yield.
PRL

I do, however, still favor shortening the description as I suggested.  Don't emphasize the bad past behavior of the program.  Also that contains a misspelling, "buginning".


Peter

 
 
 

 

One intiative of mine not yet mentioned is fixing of envelopes to treat discontinuities more correctly.  Pictures might be made, but I wouldn't bother.  Appendix material.

PRL


  • The section on clip moving commands gets too deep into detail.  I would move earlier: "The aim is that they have similar functionality to using the mouse with the shift tool. So Clip left/right is roughly equivalent to clicking in the focused track at the time given by selection start, and dragging one pixel to the left/right."  And I would move all the rest after the list of eight onto some other page.
  • I would rather just strike the sentence "This is particularly useful when recording as previously in these cases Audacity used to silently, with no warning, re-use the space at the buginning of your project, corrupting your recording."  I don't like emphasizing how we used to screw up.  Just describe the new thing positively.
The disk space thing is almost surely a thing for the appendix, as not happening in the ordinary course of things.  Or do you disagree, that this was a much complained of problem whose resolution we should highlight?
 
  • Wordings and typos
    • Under extended menus, do we want to spell out the abbreviation VI ?
    • "Many place" should say "places"
    • Remove extra spaces before period after "Audacity Wiki"
  • I only ask, should extra space be given over to old logo and menu images?  Or do they only distract from the important things?

PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Request a few changes to new Features page

Paul Licameli
In reply to this post by James Crook


On Fri, Jul 21, 2017 at 2:30 PM, James Crook <[hidden email]> wrote:
On 7/21/2017 6:45 PM, Peter Sampson wrote:
I do *not* want to move the low disk space warning to the appendix.
The main reason for this is that it has long been listed on the Wikipedia
page about Audacity as a major drawback.

Hence I want to draw primary attention to this.
+1.
But note that http://bugzilla.audacityteam.org/show_bug.cgi?id=437 (P2) is still open so we are not yet ready to delete that text from Wikipedia.

--James.

Bug 437 is really fix made months ago, if it is understood that the scope of the bug shall not include the suggestions that Audacity could detect a "yellow zone" of disk use and warn you before attempting an operation.

There was also a suggestion somewhere that we estimate size requirements for an export before we do it.  That won't happen for 2.2.0.

Things are now written so that Audacity saves, or exports, or computes an effect on a big project, until it discovers disk exhaustion.  But then, if I made no mistakes, Audacity backs out of the operation and leaves the project in a consistent state as it was before, or in case of recording, retains as much as possible, and does not proceed further oblivious to the error condition, and alerts the user.

I have read up the comment thread in bug 437.  I think I have satisfied it and can leave the other ideas for enhancement.

Any disagreement?

PRL

 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Loading...