Signed jc11

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Signed jc11

James Crook
I've just shared signed jc11 windows exe, zip and mac dmg with Gale,
Peter, Steve, Cliff, Paul.

If this is still looking good in a couple of days, they'll get renamed
as RC1 and get wider testing.

--James.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc11

James Crook
I've just noticed that the dmg has a plug-ins directory inside the
plug-ins directory.  Fortunately users don't see duplicated nyquist
plug-ins from this.  It does lead to a slight increase in size of the app.

If I need to do a respin for other reasons I'll fix this.

--James.


On 2/1/2017 6:29 PM, James Crook wrote:

> I've just shared signed jc11 windows exe, zip and mac dmg with Gale,
> Peter, Steve, Cliff, Paul.
>
> If this is still looking good in a couple of days, they'll get renamed
> as RC1 and get wider testing.
>
> --James.
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc11

Peter Sampson-2
It still bothers me that we have done nothing to deal with the way that
2.1.3 (jc11) can have two shortcuts present in the audacity.cfg file with
the same key/key-combination but for two different commands - and
the user gets no warning of this - nor are they offered corrective action.

Steps to reproduce:
1) In 2.1.2 set a shortcut ALT+Left for "Studio Fade Out"
2) this shortcut works fine
3) Save the audacity.cfg file
4) Install jc11
5) clear audacity.cfg and restore the one created in step 3
(to get the user's preferred setup)
6) record adio and select
7) Use ALT+Left
8) Nothing happens

Now this is because in 2.1.3 we have introduced the two new default shortcuts:
ALT+Left Move to next label
ALT+Right Move to right label

Now, using the steps above as the user has created no labels at step 8 the user
gets very confused by nothing happening.

The user can correct this by going to Preferences>Keyboard and deleting the
ALT+Left shortcut for "Move to next label" retaining theit own one for "Studio
Fade Out".

---------------------------------------------------------------------

This is exacerbated by the fact that this recurs with a newly created, modified
saves and restored audacity.cfg file under 2.1.3 jc11.

Steps to reproduce:
1) Delete all existing .cfg files
2) Run jc11 getting defauly audacity.cf
3) Reset Preferences to your preferred settings
4) In particular create shortcut ALt+Right for "Studio Fade Out"
5) Audacity will tell you that that shotcut already exists for "Move to next label"
and ask if you want to overwite it.
6) say Yes to overwriting
7) use ALT-Right to now do a Studio Fade Out
8) Exit Audacity
9) Save your carefully prepared audacity.cfg file
10) delete audacity's .cfg files
11) run jc11 and note that in Prefs there is only the single entry fir Alt+Right
12) Exit Audacity ande delete auudacity's cfg files
13) restore your carefully prepared and saved audacity.cfg
14) run jc11
10 go to Prefs>Keyboard and note thate there are now again the two conflicting
entries for Alt+Right.

----------------------------------------------------------------------------------------


We should either be warning the user of the presence of dual shortcuts at
a) startup of Audacity, or
b) invoking the shortcut

And ideally we should offer an ability to correct this:
c) with a) above we could ask which on ethe user wants to choose
d) with b) above we could either do as c) or ask the user to choose dynamivally
each time they use the shortcut.

This is clearly *not* a show-stopper, but do we want to log this as a P3 bug on
Bugzilla and Release Note it?

Thanks,
Peter.



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc11

Peter Sampson-2
But apart from that and a very minor LAME installation glitch on Mac
jc11 is looking good so far on both my W10 laptop and my Macbook
Pro with Sierra macOS 10.12.3

Peter

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc11

James Crook
In reply to this post by Peter Sampson-2
Yes.  Worth logging as a bug.  I'd suggest P4 and Gale can tweak to P3 if he thinks it merits a release note.


On 2/2/2017 12:18 PM, Peter Sampson wrote:
It still bothers me that we have done nothing to deal with the way that
2.1.3 (jc11) can have two shortcuts present in the audacity.cfg file with
the same key/key-combination but for two different commands - and
the user gets no warning of this - nor are they offered corrective action.

Steps to reproduce:
1) In 2.1.2 set a shortcut ALT+Left for "Studio Fade Out"
2) this shortcut works fine
3) Save the audacity.cfg file
4) Install jc11
5) clear audacity.cfg and restore the one created in step 3
(to get the user's preferred setup)
6) record adio and select
7) Use ALT+Left
8) Nothing happens

Now this is because in 2.1.3 we have introduced the two new default
shortcuts:
ALT+Left Move to next label
ALT+Right Move to right label

Now, using the steps above as the user has created no labels at step 8 the
user
gets very confused by nothing happening.

The user can correct this by going to Preferences>Keyboard and deleting the
ALT+Left shortcut for "Move to next label" retaining theit own one for
"Studio
Fade Out".

---------------------------------------------------------------------

This is exacerbated by the fact that this recurs with a newly created,
modified
saves and restored audacity.cfg file under 2.1.3 jc11.

Steps to reproduce:
1) Delete all existing .cfg files
2) Run jc11 getting defauly audacity.cf
3) Reset Preferences to your preferred settings
4) In particular create shortcut ALt+Right for "Studio Fade Out"
5) Audacity will tell you that that shotcut already exists for "Move to
next label"
and ask if you want to overwite it.
6) say Yes to overwriting
7) use ALT-Right to now do a Studio Fade Out
8) Exit Audacity
9) Save your carefully prepared audacity.cfg file
10) delete audacity's .cfg files
11) run jc11 and note that in Prefs there is only the single entry fir
Alt+Right
12) Exit Audacity ande delete auudacity's cfg files
13) restore your carefully prepared and saved audacity.cfg
14) run jc11
10 go to Prefs>Keyboard and note thate there are now again the two
conflicting
entries for Alt+Right.

----------------------------------------------------------------------------------------


We should either be warning the user of the presence of dual shortcuts at
a) startup of Audacity, or
b) invoking the shortcut

And ideally we should offer an ability to correct this:
c) with a) above we could ask which on ethe user wants to choose
d) with b) above we could either do as c) or ask the user to choose
dynamivally
each time they use the shortcut.

This is clearly *not* a show-stopper, but do we want to log this as a P3
bug on
Bugzilla and Release Note it?

Thanks,
Peter.



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc11

Peter Sampson-2
Ok I've given jc11 a good "run around the block" with my usual workflows
on W10 and it is holding up fine.

I'll do similar workflow testing on Mac later.

Peter.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Fwd: Signed jc11

James Crook
In reply to this post by James Crook

I've just shared signed jc12 windows exe, zip and mac dmg with Gale,
Peter, Steve, Cliff, Bill, Paul.

If this is still looking good tomorrow, they'll get renamed as RC1 and
get wider testing.

--James.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Fwd: Signed jc11

Peter Sampson-2
jc12 runs fine on my W10 laptop with the latest reservations I have for
bug 1580:
http://bugzilla.audacityteam.org/show_bug.cgi?id=1580#c25

Will be testing jc12 on Mac on my Sierra Macbook later this afternoon
(I have to pop out for a while right now).

Cheers,
Peter.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc12

Cliff Scott
In reply to this post by James Crook

> On Feb 8, 2017, at 6:00 AM, James Crook <[hidden email]> wrote:
>
>
> I've just shared signed jc12 windows exe, zip and mac dmg with Gale,
> Peter, Steve, Cliff, Bill, Paul.
>
> If this is still looking good tomorrow, they'll get renamed as RC1 and
> get wider testing.
>
> --James.

Fresh install on Mac Sierra 10.12.3 to a new location with the audacity directory in ~/Library/Application Support/audacity renamed.

Plugins including FFMpeg and Lame all available and found in Admin, Standard User and Guest.
Note: This is different than Peter's experience where he had to reinstall Lame in the Guest. Both Lame and FFMpeg are in the standard system directories so why Lame would be found even in the Guest on mine and not on his I don't know.

Admin:
As expected, no duplicate effects in dropdown list after enabling all via Plugin Manager.
Open - Opens the Applications Folder - no change from previous behavior, but still a strange place to open.
Note: Open remembers the last Open command, not just from the File menu. Imported keyboard shortcuts and the next Open from the File menu remembered that location.
Save/Save As - /Documents initially. Remembers location after first usage.
Export, Export Multiple - /Documents initially. Remembers location after first usage.

Standard User:
As mentioned above, all plugins, FFMpeg & Lame found.
Duplicate plugins listed because the pluginregistry.cfg was still there from jc11.
Open, Save & Export folders as expected.

Guest:
Again, all plugins, FFMpeg & Lame found.
All seems good here as well.

Noted a few things in the process of testing that I will mention in another thread for things to consider for 2.1.4.

Good to go in my book unless something strange pops up.

Cliff


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bug 1580 Jc12.

James Crook
In reply to this post by Peter Sampson-2
Thanks for this and your more detailed follow up on Mac.

I thought what you were seeing with 1580 was simply that you were using
the old audacity.cfg with the old paths in it.  If that had been so,
that part would have been reasonable/expected.

However, I tried just SaveAs, with deleted audacity.cfg, and like you
got the /Documents/ rather than the /Documents/Audacity/ directory  -
which never happened with the debug build. Investigating I put alerts
into the code, and they showed the new code being run and giving the
correct directory, but windows still, strangely, giving /Documents/
instead.  Further changes and going back to the original code and the
problem 'went away'. Running the actual unmodified installed jc12 and
the problem was still 'gone away' there too.

For me that means that that Bug #1580 problem is now intermittent.  It's
a P2 (massively promoted from P4), and I judge OK to release with it.

--James.



On 2/8/2017 12:35 PM, Peter Sampson wrote:
> jc12 runs fine on my W10 laptop with the latest reservations I have for
> bug 1580:
> http://bugzilla.audacityteam.org/show_bug.cgi?id=1580#c25
>
> Will be testing jc12 on Mac on my Sierra Macbook later this afternoon
> (I have to pop out for a while right now).
>
> Cheers,
> Peter.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc12

James Crook
In reply to this post by Cliff Scott
Thanks Cliff,
Thanks too for 2.1.4 things being a separate thread.
--James.


On 2/8/2017 5:43 PM, Cliff Scott wrote:

>> On Feb 8, 2017, at 6:00 AM, James Crook <[hidden email]> wrote:
>>
>>
>> I've just shared signed jc12 windows exe, zip and mac dmg with Gale,
>> Peter, Steve, Cliff, Bill, Paul.
>>
>> If this is still looking good tomorrow, they'll get renamed as RC1 and
>> get wider testing.
>>
>> --James.
> Fresh install on Mac Sierra 10.12.3 to a new location with the audacity directory in ~/Library/Application Support/audacity renamed.
>
> Plugins including FFMpeg and Lame all available and found in Admin, Standard User and Guest.
> Note: This is different than Peter's experience where he had to reinstall Lame in the Guest. Both Lame and FFMpeg are in the standard system directories so why Lame would be found even in the Guest on mine and not on his I don't know.
>
> Admin:
> As expected, no duplicate effects in dropdown list after enabling all via Plugin Manager.
> Open - Opens the Applications Folder - no change from previous behavior, but still a strange place to open.
> Note: Open remembers the last Open command, not just from the File menu. Imported keyboard shortcuts and the next Open from the File menu remembered that location.
> Save/Save As - /Documents initially. Remembers location after first usage.
> Export, Export Multiple - /Documents initially. Remembers location after first usage.
>
> Standard User:
> As mentioned above, all plugins, FFMpeg & Lame found.
> Duplicate plugins listed because the pluginregistry.cfg was still there from jc11.
> Open, Save & Export folders as expected.
>
> Guest:
> Again, all plugins, FFMpeg & Lame found.
> All seems good here as well.
>
> Noted a few things in the process of testing that I will mention in another thread for things to consider for 2.1.4.
>
> Good to go in my book unless something strange pops up.
>
> Cliff
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

David Bailes-3
In reply to this post by James Crook
I was just having a look around to see if there was an environment variable for the documents folder. There isn't, but came across this:

From the top answer, it looks like /documents/Audacity is going to fail on Windows XP, and if the Windows display language is not English.

From another thread, it looks like it may also fail if someone has changed the location of their documents folder. I'm not sure about whether this is true - would need testing.

David.

On Wed, Feb 8, 2017 at 5:52 PM, James Crook <[hidden email]> wrote:
Thanks for this and your more detailed follow up on Mac.

I thought what you were seeing with 1580 was simply that you were using
the old audacity.cfg with the old paths in it.  If that had been so,
that part would have been reasonable/expected.

However, I tried just SaveAs, with deleted audacity.cfg, and like you
got the /Documents/ rather than the /Documents/Audacity/ directory  -
which never happened with the debug build. Investigating I put alerts
into the code, and they showed the new code being run and giving the
correct directory, but windows still, strangely, giving /Documents/
instead.  Further changes and going back to the original code and the
problem 'went away'. Running the actual unmodified installed jc12 and
the problem was still 'gone away' there too.

For me that means that that Bug #1580 problem is now intermittent.  It's
a P2 (massively promoted from P4), and I judge OK to release with it.

--James.



On 2/8/2017 12:35 PM, Peter Sampson wrote:
> jc12 runs fine on my W10 laptop with the latest reservations I have for
> bug 1580:
> http://bugzilla.audacityteam.org/show_bug.cgi?id=1580#c25
>
> Will be testing jc12 on Mac on my Sierra Macbook later this afternoon
> (I have to pop out for a while right now).
>
> Cheers,
> Peter.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

James Crook
On 2/8/2017 6:50 PM, David Bailes wrote:

> I was just having a look around to see if there was an environment variable
> for the documents folder. There isn't, but came across this:
> http://stackoverflow.com/questions/3492920/is-there-a-system-defined-environment-variable-for-documents-directory
>
> >From the top answer, it looks like /documents/Audacity is going to fail on
> Windows XP, and if the Windows display language is not English.
>
> >From another thread, it looks like it may also fail if someone has changed
> the location of their documents folder. I'm not sure about whether this is
> true - would need testing.
>
> David.
The way I have it set up, Audacity should create the
Users/<name>/Documents/Audacity directory if it doesn't exist already.  
It won't use Users/<name>/Dokumente/Audacity by default on a German
system.  The user can though choose the directory to use themselves.  
The Users/<name>/Documents/Audacity directory is only a default offered
to the user.

I think that means that these 'failure' cases are OK.
Our approach is always subject to future improvement in 2.2.0.

I could have been smarter and used:
GetAppDocumentsDir()
http://docs.wxwidgets.org/trunk/classwx_standard_paths.html#aa87a172690af8f7535cc37f2e9b59c43
And that might localise correctly.

--James.



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

Gale
Administrator
I've not tested this repeatedly (which seems to be required) but I did
not have Peter's problem on several "Save Project As" in jc11 on
Windows XP.

Am I right in thinking this problem was always potentially there right
from the change in
http://bugzilla.audacityteam.org/show_bug.cgi?id=1304 ?

I do recall after the 1304 fix that Save Project As would tend to use the
Windows path until the next File > Close. But after the fix where we added
[SaveAs] path to audacity.cfg I have not seen any inconsistency.



Gale


On 8 February 2017 at 19:35, James Crook <[hidden email]> wrote:

> On 2/8/2017 6:50 PM, David Bailes wrote:
>> I was just having a look around to see if there was an environment variable
>> for the documents folder. There isn't, but came across this:
>> http://stackoverflow.com/questions/3492920/is-there-a-system-defined-environment-variable-for-documents-directory
>>
>> >From the top answer, it looks like /documents/Audacity is going to fail on
>> Windows XP, and if the Windows display language is not English.
>>
>> >From another thread, it looks like it may also fail if someone has changed
>> the location of their documents folder. I'm not sure about whether this is
>> true - would need testing.
>>
>> David.
> The way I have it set up, Audacity should create the
> Users/<name>/Documents/Audacity directory if it doesn't exist already.
> It won't use Users/<name>/Dokumente/Audacity by default on a German
> system.  The user can though choose the directory to use themselves.
> The Users/<name>/Documents/Audacity directory is only a default offered
> to the user.
>
> I think that means that these 'failure' cases are OK.
> Our approach is always subject to future improvement in 2.2.0.
>
> I could have been smarter and used:
> GetAppDocumentsDir()
> http://docs.wxwidgets.org/trunk/classwx_standard_paths.html#aa87a172690af8f7535cc37f2e9b59c43
> And that might localise correctly.
>
> --James.
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Signed jc12

Gale
Administrator
In reply to this post by Cliff Scott
I deleted audacity.cfg and pluginregistry.cfg then ran my installed
2.1.2 from Program Files(x86) on Win 10. Opened Plug-in Manager
and OK then quit.

Then installed jc12.exe over 2.1.2 into Program Files(x86). Minor
installer bug - clicktrack.ny isn't removed from the Plug-ins folder.
So Click Track is available and working in Generate Menu above
Rhythm Track.

We probably want to change the release announcement which says
"Rhythm Track (was called Click Track)".

References to Click Track were expunged from the Manual when we
renamed Click Track to Rhythm Track.



Gale


On 8 February 2017 at 17:43, Cliff Scott <[hidden email]> wrote:

>
>> On Feb 8, 2017, at 6:00 AM, James Crook <[hidden email]> wrote:
>>
>>
>> I've just shared signed jc12 windows exe, zip and mac dmg with Gale,
>> Peter, Steve, Cliff, Bill, Paul.
>>
>> If this is still looking good tomorrow, they'll get renamed as RC1 and
>> get wider testing.
>>
>> --James.
>
> Fresh install on Mac Sierra 10.12.3 to a new location with the audacity directory in ~/Library/Application Support/audacity renamed.
>
> Plugins including FFMpeg and Lame all available and found in Admin, Standard User and Guest.
> Note: This is different than Peter's experience where he had to reinstall Lame in the Guest. Both Lame and FFMpeg are in the standard system directories so why Lame would be found even in the Guest on mine and not on his I don't know.
>
> Admin:
> As expected, no duplicate effects in dropdown list after enabling all via Plugin Manager.
> Open - Opens the Applications Folder - no change from previous behavior, but still a strange place to open.
> Note: Open remembers the last Open command, not just from the File menu. Imported keyboard shortcuts and the next Open from the File menu remembered that location.
> Save/Save As - /Documents initially. Remembers location after first usage.
> Export, Export Multiple - /Documents initially. Remembers location after first usage.
>
> Standard User:
> As mentioned above, all plugins, FFMpeg & Lame found.
> Duplicate plugins listed because the pluginregistry.cfg was still there from jc11.
> Open, Save & Export folders as expected.
>
> Guest:
> Again, all plugins, FFMpeg & Lame found.
> All seems good here as well.
>
> Noted a few things in the process of testing that I will mention in another thread for things to consider for 2.1.4.
>
> Good to go in my book unless something strange pops up.
>
> Cliff
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

Gale
Administrator
In reply to this post by Gale
My further testing reveals this. Each run was after deleting
audacity.cfg.

* 1580 remained completely fixed in the nightly I built from HEAD
   which is installed in a subfolder on my S:\ drive. By "installed"
   I mean I use the installer I build to put it there.

* Then I tested jc12 installed into Program Files (x86).  Save Project,
   Save Project As, Export or Export Selected always open to the
   Windows path. Not intermittent, but repeatable for me.

* Then I installed my nightly over jc12 in Program Files (x86). Now
   it behaves like jc12, and so now does my nightly in the S:\ subfolder.

 * Uninstalling the nightly does not change the behaviour of my nightly
    in S:\.

I suppose my next step would be to find out whether this has been the
same since the fix for 1304.

I had believed Windows stores this path in a single Registry key but now
I think it may be more complicated than that. So I am not sure how to
remove the path right now, only how to change it by using 2.1.2, until I
start digging more.


Gale

On 8 February 2017 at 20:14, Gale Andrews <[hidden email]> wrote:

> I've not tested this repeatedly (which seems to be required) but I did
> not have Peter's problem on several "Save Project As" in jc11 on
> Windows XP.
>
> Am I right in thinking this problem was always potentially there right
> from the change in
> http://bugzilla.audacityteam.org/show_bug.cgi?id=1304 ?
>
> I do recall after the 1304 fix that Save Project As would tend to use the
> Windows path until the next File > Close. But after the fix where we added
> [SaveAs] path to audacity.cfg I have not seen any inconsistency.
>
>
>
> Gale
>
>
> On 8 February 2017 at 19:35, James Crook <[hidden email]> wrote:
>> On 2/8/2017 6:50 PM, David Bailes wrote:
>>> I was just having a look around to see if there was an environment variable
>>> for the documents folder. There isn't, but came across this:
>>> http://stackoverflow.com/questions/3492920/is-there-a-system-defined-environment-variable-for-documents-directory
>>>
>>> >From the top answer, it looks like /documents/Audacity is going to fail on
>>> Windows XP, and if the Windows display language is not English.
>>>
>>> >From another thread, it looks like it may also fail if someone has changed
>>> the location of their documents folder. I'm not sure about whether this is
>>> true - would need testing.
>>>
>>> David.
>> The way I have it set up, Audacity should create the
>> Users/<name>/Documents/Audacity directory if it doesn't exist already.
>> It won't use Users/<name>/Dokumente/Audacity by default on a German
>> system.  The user can though choose the directory to use themselves.
>> The Users/<name>/Documents/Audacity directory is only a default offered
>> to the user.
>>
>> I think that means that these 'failure' cases are OK.
>> Our approach is always subject to future improvement in 2.2.0.
>>
>> I could have been smarter and used:
>> GetAppDocumentsDir()
>> http://docs.wxwidgets.org/trunk/classwx_standard_paths.html#aa87a172690af8f7535cc37f2e9b59c43
>> And that might localise correctly.
>>
>> --James.
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

Peter Sampson-2
Let us not forget that although we may not have tightened this down
completely - it is substantially better than the situation we had before
whereby Audacity would default-suggest the location where the user
had installed Audacity as a suitable location for saving and exporting
when this was patently not suitable.

Users who are upgrading may indeed prefer that their last-used save and
export locations be remembered and used on their first use after upgrade.

But we do do to get to the bottom of what is going on here between
Audacity and Windows - and we should ultimately be seeking to ensure
consistency between Export Audio and Export Multiple (and Export Labels
come to that).

But I do not see what we have now as in any way a blocker for 2.1.3,
I do see it as an improvement.

Cheers,
Peter.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

James Crook
In reply to this post by Gale
Gale wrote:
> I suppose my next step would be to find out whether this has been the
> same since the fix for 1304.
For me the next step, and it does not need to be before release, is to
reproduce this on a debug build with debug wxWidgets and trace it on
down deeper into wxWidgets.  I've done some looking/eyeballing the code,
and there is nothing that we are doing wrong that leaps out.

A bit more digging and I found this text:

> Windows 7:
> If lpstrInitialDir has the same value as was passed the first time the
> application used an Open or Save As dialog box, the path most recently
> selected by the user is used as the initial directory.
> Otherwise, if lpstrFile contains a path, that path is the initial
> directory.
> Otherwise, if lpstrInitialDir is not NULL, it specifies the initial
> directory.
> If lpstrInitialDir is NULL and the current directory contains any
> files of the specified filter types, the initial directory is the
> current directory.
> Otherwise, the initial directory is the personal files directory of
> the current user.
> Otherwise, the initial directory is the Desktop folder.
>
> Windows 2000/XP/Vista:
> If lpstrFile contains a path, that path is the initial directory.
> Otherwise, lpstrInitialDir specifies the initial directory.
> Otherwise, if the application has used an Open or Save As dialog box
> in the past, the path most recently used is selected as the initial
> directory. However, if an application is not run for a long time, its
> saved selected path is discarded.
> If lpstrInitialDir is NULL and the current directory contains any
> files of the specified filter types, the initial directory is the
> current directory.
> Otherwise, the initial directory is the personal files directory of
> the current user.
> Otherwise, the initial directory is the Desktop folder.

What that means is that on Windows 7, and presumably Windows 10, by
design Windows might NOT use the directory we suggest as initial dir!
To get the behaviour we want we could put the directory in lpstrFile,
and make sure lpstrInitialDir is different to what it was the first time
the program was run (e.g. make lpstrInitialDir random).
Weird.

If this interpretation is right, then there should only be a problem
where the new Audacity.exe is copied over an existing Audacity.exe, or
where one once was, and not when it is in a new location on disk where
it has never been before.

Not a priority for 2.1.3







Peter wrote:
> it is substantially better than the situation we had before
> whereby Audacity would default-suggest the location where the user
> had installed Audacity
Yes.  I don't think Gale is suggesting that 1304 needs to be reopened,
so this issue is not blocking proceeding towards release.



On 2/9/2017 5:41 AM, Gale Andrews wrote:

> My further testing reveals this. Each run was after deleting
> audacity.cfg.
>
> * 1580 remained completely fixed in the nightly I built from HEAD
>     which is installed in a subfolder on my S:\ drive. By "installed"
>     I mean I use the installer I build to put it there.
>
> * Then I tested jc12 installed into Program Files (x86).  Save Project,
>     Save Project As, Export or Export Selected always open to the
>     Windows path. Not intermittent, but repeatable for me.
>
> * Then I installed my nightly over jc12 in Program Files (x86). Now
>     it behaves like jc12, and so now does my nightly in the S:\ subfolder.
>
>   * Uninstalling the nightly does not change the behaviour of my nightly
>      in S:\.
>
> I suppose my next step would be to find out whether this has been the
> same since the fix for 1304.
>
> I had believed Windows stores this path in a single Registry key but now
> I think it may be more complicated than that. So I am not sure how to
> remove the path right now, only how to change it by using 2.1.2, until I
> start digging more.
>
>
> Gale
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

Gale
Administrator
On 9 February 2017 at 15:29, James Crook <[hidden email]> wrote:

> Gale wrote:
>> I suppose my next step would be to find out whether this has been the
>> same since the fix for 1304.
> For me the next step, and it does not need to be before release, is to
> reproduce this on a debug build with debug wxWidgets and trace it on
> down deeper into wxWidgets.  I've done some looking/eyeballing the code,
> and there is nothing that we are doing wrong that leaps out.
>
> A bit more digging and I found this text:
>
>> Windows 7:
>> If lpstrInitialDir has the same value as was passed the first time the
>> application used an Open or Save As dialog box, the path most recently
>> selected by the user is used as the initial directory.
>> Otherwise, if lpstrFile contains a path, that path is the initial
>> directory.
>> Otherwise, if lpstrInitialDir is not NULL, it specifies the initial
>> directory.
>> If lpstrInitialDir is NULL and the current directory contains any
>> files of the specified filter types, the initial directory is the
>> current directory.
>> Otherwise, the initial directory is the personal files directory of
>> the current user.
>> Otherwise, the initial directory is the Desktop folder.
>>
>> Windows 2000/XP/Vista:
>> If lpstrFile contains a path, that path is the initial directory.
>> Otherwise, lpstrInitialDir specifies the initial directory.
>> Otherwise, if the application has used an Open or Save As dialog box
>> in the past, the path most recently used is selected as the initial
>> directory. However, if an application is not run for a long time, its
>> saved selected path is discarded.
>> If lpstrInitialDir is NULL and the current directory contains any
>> files of the specified filter types, the initial directory is the
>> current directory.
>> Otherwise, the initial directory is the personal files directory of
>> the current user.
>> Otherwise, the initial directory is the Desktop folder.
>
> What that means is that on Windows 7, and presumably Windows 10, by
> design Windows might NOT use the directory we suggest as initial dir!
> To get the behaviour we want we could put the directory in lpstrFile,
> and make sure lpstrInitialDir is different to what it was the first time
> the program was run (e.g. make lpstrInitialDir random).
> Weird.

I fear I don't understand the relationship if any of those strings to the
registry key
HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\ComDlg32\LastVisitedPidlMRULegacy

but on my machine this key does now appear to be what Audacity is
reading. If I delete that key and there is no audacity.cfg then the Save
 commands and single Export commands open at Documents\Audacity.

In 2.1.2 in its own folder in S:\ in the same circumstances (no key, no
audacity.cfg) the Save/Export dialogues sometimes open in Documents
but usually in the current directory (I presume due to the logic cited
above)?


> If this interpretation is right, then there should only be a problem
> where the new Audacity.exe is copied over an existing Audacity.exe, or
> where one once was, and not when it is in a new location on disk where
> it has never been before.

Using the jc12 installer to install to a new folder on S:\ where Audacity
has definitely never been before,  I have the same problem if the above
registry key exists - the Save and single Export commands open
wherever that key points to.

It may be true that I only now receive that behaviour there and where the
nightly build is because I installed my nightly over jc12. I had previously
installed jc12 over 2.1.2 in Program Files and it did not affect my nightly,
which appeared to show 1580 as completely fixed regardless if the above
registry key existed.


> Not a priority for 2.1.3
>
> Peter wrote:
>> it is substantially better than the situation we had before
>> whereby Audacity would default-suggest the location where the user
>> had installed Audacity
> Yes.  I don't think Gale is suggesting that 1304 needs to be reopened,
> so this issue is not blocking proceeding towards release.

I suppose without a completely fresh Windows partition it's impossible
to be sure, but if the absence of the registry key is sufficient test, then
yes a new user of Audacity will see Save and single Export open to
Audacity\Documents.


Gale

> On 2/9/2017 5:41 AM, Gale Andrews wrote:
>> My further testing reveals this. Each run was after deleting
>> audacity.cfg.
>>
>> * 1580 remained completely fixed in the nightly I built from HEAD
>>     which is installed in a subfolder on my S:\ drive. By "installed"
>>     I mean I use the installer I build to put it there.
>>
>> * Then I tested jc12 installed into Program Files (x86).  Save Project,
>>     Save Project As, Export or Export Selected always open to the
>>     Windows path. Not intermittent, but repeatable for me.
>>
>> * Then I installed my nightly over jc12 in Program Files (x86). Now
>>     it behaves like jc12, and so now does my nightly in the S:\ subfolder.
>>
>>   * Uninstalling the nightly does not change the behaviour of my nightly
>>      in S:\.
>>
>> I suppose my next step would be to find out whether this has been the
>> same since the fix for 1304.
>>
>> I had believed Windows stores this path in a single Registry key but now
>> I think it may be more complicated than that. So I am not sure how to
>> remove the path right now, only how to change it by using 2.1.2, until I
>> start digging more.
>>
>>
>> Gale
>>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug 1580 Jc12.

David Bailes-3
On Thu, Feb 9, 2017 at 6:08 PM, Gale Andrews <[hidden email]> wrote:
On 9 February 2017 at 15:29, James Crook <[hidden email]> wrote:
> Gale wrote:
>> I suppose my next step would be to find out whether this has been the
>> same since the fix for 1304.
> For me the next step, and it does not need to be before release, is to
> reproduce this on a debug build with debug wxWidgets and trace it on
> down deeper into wxWidgets.  I've done some looking/eyeballing the code,
> and there is nothing that we are doing wrong that leaps out.
>
> A bit more digging and I found this text:
>
>> Windows 7:
>> If lpstrInitialDir has the same value as was passed the first time the
>> application used an Open or Save As dialog box, the path most recently
>> selected by the user is used as the initial directory.
>> Otherwise, if lpstrFile contains a path, that path is the initial
>> directory.
>> Otherwise, if lpstrInitialDir is not NULL, it specifies the initial
>> directory.
>> If lpstrInitialDir is NULL and the current directory contains any
>> files of the specified filter types, the initial directory is the
>> current directory.
>> Otherwise, the initial directory is the personal files directory of
>> the current user.
>> Otherwise, the initial directory is the Desktop folder.
>>
>> Windows 2000/XP/Vista:
>> If lpstrFile contains a path, that path is the initial directory.
>> Otherwise, lpstrInitialDir specifies the initial directory.
>> Otherwise, if the application has used an Open or Save As dialog box
>> in the past, the path most recently used is selected as the initial
>> directory. However, if an application is not run for a long time, its
>> saved selected path is discarded.
>> If lpstrInitialDir is NULL and the current directory contains any
>> files of the specified filter types, the initial directory is the
>> current directory.
>> Otherwise, the initial directory is the personal files directory of
>> the current user.
>> Otherwise, the initial directory is the Desktop folder.
>
> What that means is that on Windows 7, and presumably Windows 10, by
> design Windows might NOT use the directory we suggest as initial dir!
> To get the behaviour we want we could put the directory in lpstrFile,
> and make sure lpstrInitialDir is different to what it was the first time
> the program was run (e.g. make lpstrInitialDir random).
> Weird.

I fear I don't understand the relationship if any of those strings to the
registry key
HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\ComDlg32\LastVisitedPidlMRULegacy

but on my machine this key does now appear to be what Audacity is
reading. If I delete that key and there is no audacity.cfg then the Save
 commands and single Export commands open at Documents\Audacity.

In 2.1.2 in its own folder in S:\ in the same circumstances (no key, no
audacity.cfg) the Save/Export dialogues sometimes open in Documents
but usually in the current directory (I presume due to the logic cited
above)?


> If this interpretation is right, then there should only be a problem
> where the new Audacity.exe is copied over an existing Audacity.exe, or
> where one once was, and not when it is in a new location on disk where
> it has never been before.

Using the jc12 installer to install to a new folder on S:\ where Audacity
has definitely never been before,  I have the same problem if the above
registry key exists - the Save and single Export commands open
wherever that key points to.

It may be true that I only now receive that behaviour there and where the
nightly build is because I installed my nightly over jc12. I had previously
installed jc12 over 2.1.2 in Program Files and it did not affect my nightly,
which appeared to show 1580 as completely fixed regardless if the above
registry key existed.


> Not a priority for 2.1.3
>
> Peter wrote:
>> it is substantially better than the situation we had before
>> whereby Audacity would default-suggest the location where the user
>> had installed Audacity
> Yes.  I don't think Gale is suggesting that 1304 needs to be reopened,
> so this issue is not blocking proceeding towards release.

I suppose without a completely fresh Windows partition it's impossible
to be sure,

I would have thought that just creating a new user account would be sufficient.
 
but if the absence of the registry key is sufficient test, then
yes a new user of Audacity will see Save and single Export open to
Audacity\Documents.

And I would assume that a user moving to a newer version of audacity would expect her previous save location to be used, rather than any new default.

David.
 


Gale

> On 2/9/2017 5:41 AM, Gale Andrews wrote:
>> My further testing reveals this. Each run was after deleting
>> audacity.cfg.
>>
>> * 1580 remained completely fixed in the nightly I built from HEAD
>>     which is installed in a subfolder on my S:\ drive. By "installed"
>>     I mean I use the installer I build to put it there.
>>
>> * Then I tested jc12 installed into Program Files (x86).  Save Project,
>>     Save Project As, Export or Export Selected always open to the
>>     Windows path. Not intermittent, but repeatable for me.
>>
>> * Then I installed my nightly over jc12 in Program Files (x86). Now
>>     it behaves like jc12, and so now does my nightly in the S:\ subfolder.
>>
>>   * Uninstalling the nightly does not change the behaviour of my nightly
>>      in S:\.
>>
>> I suppose my next step would be to find out whether this has been the
>> same since the fix for 1304.
>>
>> I had believed Windows stores this path in a single Registry key but now
>> I think it may be more complicated than that. So I am not sure how to
>> remove the path right now, only how to change it by using 2.1.2, until I
>> start digging more.
>>
>>
>> Gale
>>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-quality

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
12
Loading...