Small theme issues

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Small theme issues

Paul Licameli
1. This should perhaps interest David most.  When you navigate toolbar buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool dock, then TAB key), in Classic and Light themes the focus is very clearly drawn, on Mac and on Windows, as a stippled rectangle.  But note the differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely invisible for Dark and High Contrast themes.

2.  I made a change here to the Light theme images for backgrounds of Transport toolbar buttons on Mac.  I believe the top and bottom rows of pixels made their edges look odd and I pasted the corresponding parts of the Classic images over them.  I leave it to James to decide whether to merge this.



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Small theme issues

James Crook
On 6/16/2017 6:12 AM, Paul Licameli wrote:
1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

2.  I made a change here to the Light theme images for backgrounds of
Transport toolbar buttons on Mac.  I believe the top and bottom rows of
pixels made their edges look odd and I pasted the corresponding parts of
the Classic images over them.  I leave it to James to decide whether to
merge this.

https://github.com/Paul-Licameli/audacity/commit/b798a2f468e8e6111c1d38185ff16b7630563595
Like the idea/change but I did not merge, as whatever you did in editing brought in the 'black dots' at the four corners of the Windows transport buttons.  I think your 100% transparent very light colour became 100% transparent black, probably because of using layers in GIMP during editing.  Not visible in GIMP, but is visible in Audacity.

Do you want to have another go, or will I?

--James.







------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Small theme issues

Paul Licameli


On Fri, Jun 16, 2017 at 4:43 AM, James Crook <[hidden email]> wrote:
On 6/16/2017 6:12 AM, Paul Licameli wrote:
1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

2.  I made a change here to the Light theme images for backgrounds of
Transport toolbar buttons on Mac.  I believe the top and bottom rows of
pixels made their edges look odd and I pasted the corresponding parts of
the Classic images over them.  I leave it to James to decide whether to
merge this.

https://github.com/Paul-Licameli/audacity/commit/b798a2f468e8e6111c1d38185ff16b7630563595
Like the idea/change but I did not merge, as whatever you did in editing brought in the 'black dots' at the four corners of the Windows transport buttons.  I think your 100% transparent very light colour became 100% transparent black, probably because of using layers in GIMP during editing.  Not visible in GIMP, but is visible in Audacity.

Do you want to have another go, or will I?

--James.


I followed the procedure of building with EXPERIMENTAL_THEME_PREFS, saving files, editing images, loading files, and saving soucre.

Does the save button on Mac not save the Windows images?  Is that how they got replaced with black squares?

PRL

 




      

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Small theme issues

James Crook
On 6/16/2017 3:22 PM, Paul Licameli wrote:
On Fri, Jun 16, 2017 at 4:43 AM, James Crook [hidden email] wrote:

On 6/16/2017 6:12 AM, Paul Licameli wrote:

1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

2.  I made a change here to the Light theme images for backgrounds of
Transport toolbar buttons on Mac.  I believe the top and bottom rows of
pixels made their edges look odd and I pasted the corresponding parts of
the Classic images over them.  I leave it to James to decide whether to
merge this.
https://github.com/Paul-Licameli/audacity/commit/b798a2f468e8e6111c1d38185ff16b7630563595

Like the idea/change but I did not merge, as whatever you did in editing
brought in the 'black dots' at the four corners of the Windows transport
buttons.  I think your 100% transparent very light colour became 100%
transparent black, probably because of using layers in GIMP during
editing.  Not visible in GIMP, but is visible in Audacity.

Do you want to have another go, or will I?

--James.


I followed the procedure of building with EXPERIMENTAL_THEME_PREFS, saving
files, editing images, loading files, and saving soucre.

Does the save button on Mac not save the Windows images? 
It does save them.
 Is that how they
got replaced with black squares?
Only their corners (which are transparent light) got replaced.
That is most likely because in your editing 'transparent light' got replaced by 'transparent black'.  It is quite easy to have that happen when using the GIMP and merging layers down.

Now Audacity will respect alpha in the backgrounds of AButtons, so either 100% transparent white or 100% transparent black are fine.
https://github.com/audacity/audacity/commit/b293ad0b5012602e0c7a8150cc82c4b7a97d31b9

An additional problem is that you had 'Blend system and Audacity theme' checked when you loaded the Light theme, so the darker grey mac background colour got written out to the theme, so the interface became darker on Windows.

Note that the filename for LightThemeAsCeeCode.h should be in the header (it is not checked, but it helps human readers).  Autogeneration does not update that file name.






PRL







------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Audacity-quality mailing [hidden email]



------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



      

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Small theme issues

Paul Licameli


On Fri, Jun 16, 2017 at 11:08 AM, James Crook <[hidden email]> wrote:
On 6/16/2017 3:22 PM, Paul Licameli wrote:
On Fri, Jun 16, 2017 at 4:43 AM, James Crook [hidden email] wrote:

On 6/16/2017 6:12 AM, Paul Licameli wrote:

1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

2.  I made a change here to the Light theme images for backgrounds of
Transport toolbar buttons on Mac.  I believe the top and bottom rows of
pixels made their edges look odd and I pasted the corresponding parts of
the Classic images over them.  I leave it to James to decide whether to
merge this.
https://github.com/Paul-Licameli/audacity/commit/b798a2f468e8e6111c1d38185ff16b7630563595

Like the idea/change but I did not merge, as whatever you did in editing
brought in the 'black dots' at the four corners of the Windows transport
buttons.  I think your 100% transparent very light colour became 100%
transparent black, probably because of using layers in GIMP during
editing.  Not visible in GIMP, but is visible in Audacity.

Do you want to have another go, or will I?

--James.


I followed the procedure of building with EXPERIMENTAL_THEME_PREFS, saving
files, editing images, loading files, and saving soucre.

Does the save button on Mac not save the Windows images? 
It does save them.
 Is that how they
got replaced with black squares?
Only their corners (which are transparent light) got replaced.
That is most likely because in your editing 'transparent light' got replaced by 'transparent black'.  It is quite easy to have that happen when using the GIMP and merging layers down.

But I did not edit those files at all.  The error must be somewhere in saving and reloading.
 

Now Audacity will respect alpha in the backgrounds of AButtons, so either 100% transparent white or 100% transparent black are fine.
https://github.com/audacity/audacity/commit/b293ad0b5012602e0c7a8150cc82c4b7a97d31b9

An additional problem is that you had 'Blend system and Audacity theme' checked when you loaded the Light theme, so the darker grey mac background colour got written out to the theme, so the interface became darker on Windows.

Maybe that explains it then.

PRL

 

Note that the filename for LightThemeAsCeeCode.h should be in the header (it is not checked, but it helps human readers).  Autogeneration does not update that file name.





PRL




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Audacity-quality mailing [hidden email]



------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



      

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Small theme issues

Paul Licameli

On Fri, Jun 16, 2017 at 11:12 AM, Paul Licameli <[hidden email]> wrote:


On Fri, Jun 16, 2017 at 11:08 AM, James Crook <[hidden email]> wrote:
On 6/16/2017 3:22 PM, Paul Licameli wrote:
On Fri, Jun 16, 2017 at 4:43 AM, James Crook [hidden email] wrote:

On 6/16/2017 6:12 AM, Paul Licameli wrote:

1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

2.  I made a change here to the Light theme images for backgrounds of
Transport toolbar buttons on Mac.  I believe the top and bottom rows of
pixels made their edges look odd and I pasted the corresponding parts of
the Classic images over them.  I leave it to James to decide whether to
merge this.
https://github.com/Paul-Licameli/audacity/commit/b798a2f468e8e6111c1d38185ff16b7630563595

Like the idea/change but I did not merge, as whatever you did in editing
brought in the 'black dots' at the four corners of the Windows transport
buttons.  I think your 100% transparent very light colour became 100%
transparent black, probably because of using layers in GIMP during
editing.  Not visible in GIMP, but is visible in Audacity.

Do you want to have another go, or will I?

--James.


I followed the procedure of building with EXPERIMENTAL_THEME_PREFS, saving
files, editing images, loading files, and saving soucre.

Does the save button on Mac not save the Windows images? 
It does save them.
 Is that how they
got replaced with black squares?
Only their corners (which are transparent light) got replaced.
That is most likely because in your editing 'transparent light' got replaced by 'transparent black'.  It is quite easy to have that happen when using the GIMP and merging layers down.

But I did not edit those files at all.  The error must be somewhere in saving and reloading.
 

Now Audacity will respect alpha in the backgrounds of AButtons, so either 100% transparent white or 100% transparent black are fine.
https://github.com/audacity/audacity/commit/b293ad0b5012602e0c7a8150cc82c4b7a97d31b9

An additional problem is that you had 'Blend system and Audacity theme' checked when you loaded the Light theme, so the darker grey mac background colour got written out to the theme, so the interface became darker on Windows.

Maybe that explains it then.

PRL

 

Note that the filename for LightThemeAsCeeCode.h should be in the header (it is not checked, but it helps human readers).  Autogeneration does not update that file name.





PRL



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Audacity-quality mailing [hidden email]



------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



      

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Small theme issues

James Crook
On 6/16/2017 5:06 PM, Paul Licameli wrote:
So let's try it again:

https://github.com/Paul-Licameli/audacity/commit/3edc331d2d7913b03b2df7f5e5af1fce96335f6d

PRL
Looks fine to me.  Pushed to master.
--James.





On Fri, Jun 16, 2017 at 11:12 AM, Paul Licameli [hidden email]
wrote:


On Fri, Jun 16, 2017 at 11:08 AM, James Crook [hidden email] wrote:

On 6/16/2017 3:22 PM, Paul Licameli wrote:

On Fri, Jun 16, 2017 at 4:43 AM, James Crook [hidden email] [hidden email] wrote:


On 6/16/2017 6:12 AM, Paul Licameli wrote:

1. This should perhaps interest David most.  When you navigate toolbar
buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool
dock, then TAB key), in Classic and Light themes the focus is very clearly
drawn, on Mac and on Windows, as a stippled rectangle.  But note the
differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely
invisible for Dark and High Contrast themes.

2.  I made a change here to the Light theme images for backgrounds of
Transport toolbar buttons on Mac.  I believe the top and bottom rows of
pixels made their edges look odd and I pasted the corresponding parts of
the Classic images over them.  I leave it to James to decide whether to
merge this.https://github.com/Paul-Licameli/audacity/commit/b798a2f468e8e6111c1d38185ff16b7630563595

Like the idea/change but I did not merge, as whatever you did in editing
brought in the 'black dots' at the four corners of the Windows transport
buttons.  I think your 100% transparent very light colour became 100%
transparent black, probably because of using layers in GIMP during
editing.  Not visible in GIMP, but is visible in Audacity.

Do you want to have another go, or will I?

--James.



I followed the procedure of building with EXPERIMENTAL_THEME_PREFS, saving
files, editing images, loading files, and saving soucre.

Does the save button on Mac not save the Windows images?

It does save them.

 Is that how they
got replaced with black squares?

Only their corners (which are transparent light) got replaced.
That is most likely because in your editing 'transparent light' got
replaced by 'transparent black'.  It is quite easy to have that happen when
using the GIMP and merging layers down.

But I did not edit those files at all.  The error must be somewhere in
saving and reloading.


Now Audacity will respect alpha in the backgrounds of AButtons, so either
100% transparent white or 100% transparent black are fine.
https://github.com/audacity/audacity/commit/b293ad0b5012602e
0c7a8150cc82c4b7a97d31b9

An additional problem is that you had 'Blend system and Audacity theme'
checked when you loaded the Light theme, so the darker grey mac background
colour got written out to the theme, so the interface became darker on
Windows.

Maybe that explains it then.

PRL



Note that the filename for LightThemeAsCeeCode.h should be in the header
(it is not checked, but it helps human readers).  Autogeneration does not
update that file name.





PRL





------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Audacity-quality mailing [hidden email]



------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing [hidden email]



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Audacity-quality mailing [hidden email]



------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



      

      

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Small theme issues

David Bailes-3
In reply to this post by Paul Licameli
On Fri, Jun 16, 2017 at 6:12 AM, Paul Licameli <[hidden email]> wrote:
1. This should perhaps interest David most.  When you navigate toolbar buttons, sliders, and meters by keystrokes (Ctrl+f6 to reach the top tool dock, then TAB key), in Classic and Light themes the focus is very clearly drawn, on Mac and on Windows, as a stippled rectangle.  But note the differences of details between the platforms in AColor::DrawFocus().

But on both platforms, I find the focus rectangles to be completely invisible for Dark and High Contrast themes.

The dark theme is now much better.
Just to note that if you use the Windows High contrast theme, for standard Windows controls focus is indicated by a change in background colour, rather than dotted rectangles.

David.
 

2.  I made a change here to the Light theme images for backgrounds of Transport toolbar buttons on Mac.  I believe the top and bottom rows of pixels made their edges look odd and I pasted the corresponding parts of the Classic images over them.  I leave it to James to decide whether to merge this.



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Audacity-quality mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-quality
Loading...