TimeTracks (was Re: [audacity] r12077 committed - commit a large patch by Maarten Baert...)
Locked
12
12
 
|
On 01/01/13 00:46, Leland Lucius wrote:
> May I suggest using wxMax and wxMin instead? Those appear to be undocumented. Also, they are macros rather than functions. I prefer std::min and std::max because those are standard C++ functions. Unrelated: I've done some tests with lower values for mMaxPlaybackSecsToCopy (in AudioIO.cpp). The current value is 4 seconds, but I can lower this to 0.2 seconds before I get any kind of stuttering (and even then it's only at the start). So I think 1 second should work fine. Playback starts faster with lower values because less processing is needed before playback can start, which is especially noticeable with time tracks - if mMaxPlaybackSecsToCopy is set to 4, the delay is quite noticeable. Could someone do some tests with lower values for mMaxPlaybackSecsToCopy (AudioIO.cpp around line 1201) to see whether lower values also work on other platforms? I tested only on Linux. Maarten Baert ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
|
On 12/31/2012 8:21 PM, Maarten Baert wrote:
> On 01/01/13 00:46, Leland Lucius wrote: >> May I suggest using wxMax and wxMin instead? > Those appear to be undocumented. Also, they are macros rather than > functions. I prefer std::min and std::max because those are standard C++ > functions. > Interesting that the "standard" C++ functions are giving issues. The wxMin/wxMax (Audacity does use wxWidgets ya know) are available in the 2.8 and 2.9 series, macros in 2.8 and templates in 2.9. I bet Unicode Release would actually build if you included "wx/utils.h" and changed to wxMin/wxMax. But, no biggie. I was able to get my build working here. Leland ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
|
In reply to this post by Maarten Baert
On 12/29/2012 6:05 PM, Maarten Baert wrote:
> On 29/12/12 23:30, Gale Andrews wrote: >> Maarten, >> >> Trying what is committed now (unmodified HEAD) I get the same >> errors building Unicode Release on Windows that I told you about >> when trying V1 of patch-envelope-range (which built OK on Unicode >> Debug): >> >> 26>PCMAliasBlockFile.cpp >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2589: '(' : illegal token on right side of '::' >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2059: syntax error : '::' >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2589: '(' : illegal token on right side of '::' >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2589: '(' : illegal token on right side of '::' >> 26>ODPCMAliasBlockFile.cpp >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2589: '(' : illegal token on right side of '::' >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2059: syntax error : '::' >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2589: '(' : illegal token on right side of '::' >> 26>c:\audacity svn\src\widgets\../Envelope.h(105) : error C2589: '(' : illegal token on right side of '::' >> >> At least, I assume this patch is the cause. >> >> Windows 7 x64, WxWidgets 2.8.12. > I already replied to that (off-list), did you miss it? >> I've seen similar errors before. Some windows headers define the >> macros 'min' and 'max', which obviously interfere with the functions >> std::min and std::max - you get something like std::((a < b)? a : b). >> You could add something like '#ifdef min #undef min #endif' to the top >> of Envelope.h. I'm not sure why it only happens in Release mode though. > I haven't added this in my patch though, I haven't tried building on > Windows so I don't really know whether this will solve your issue or > just create other problems elsewhere. > the preprocessor definitions for the Audacity project will prevent the error from happening. Leland ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
|
In reply to this post by Maarten Baert
On 01/01/2013 02:21, Maarten Baert wrote: ... > Unrelated: ... Oh, please don't do that! Thanks Martyn ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
|
In reply to this post by MartynShaw
I'm getting it in:
6>SimpleBlockFile.cpp 6>..\..\..\src\blockfile\SimpleBlockFile.cpp(502) : error C2065: 'MAX_PATH' : undeclared identifier MAX_PATH is a well know size on Windows and I'd bet my right eye that it'll never change. (My right eye doesn't work, so a pretty safe bet. :-D) How about just adding to Audacity.h: #ifdef __WXMSW__ #include "configwin.h" #if !defined(MAX_PATH) #define MAX_PATH 260 #endif #undef PLATFORM_MAX_PATH #define PLATFORM_MAX_PATH MAX_PATH #endif Or even better, change all uses of MAX_PATH to PLATFORM_MAX_PATH and just: #ifdef __WXMSW__ #include "configwin.h" #undef PLATFORM_MAX_PATH #define PLATFORM_MAX_PATH 260 #endif If push comes to shove, just include "dynlib.h" or "wxprec.h" and use preprocessed headers. Leland On 12/31/2012 1:58 PM, Martyn Shaw wrote: > > > On 31/12/2012 13:29, Richard Ash wrote: >> On Mon, 31 Dec 2012 02:29:16 +0100 >> Maarten Baert <[hidden email]> wrote: >> >>> On 31/12/12 00:55, Martyn Shaw wrote: >>>> Also I note that std::max(...) is in use in several other places in >>>> the Audacity code, without this problem. The only place that I see >>>> the problem is in Envelope.h and that is also the only .h file in >>>> which std::max(...) is used. Is that a coincidence, or a clue to >>>> how to make the code more cross-platform? >>> It only causes a problem when included from specific source files: >>> PCMAliasBlockFile.cpp and ODPCMAliasBlockFile.cpp. These are two of >>> the few files that include <windows.h> directly, rather than >>> including wxWidgets headers. I assume these are simply the only files >>> where Envelope.h and windows.h are included at the same time. I don't >>> quite understand why the BlockFile-related code even has to include >>> <windows.h> since they don't use any windows-specific functions. >>> Would removing those break anything? >> >> I'd very much like to loose all the #includes of windows.h except where >> the code is actually platform-dependent. I agree I can see no reason >> why it is needed in any of the blockfile code. It seems to have been >> added by Vaughan in 2008 for the switch to DLL (rather than static) >> wxWidgets, although I can't see why, as most of the commit (r7435) is >> adding precompilation header includes (which are all wx). >> >> Could someone on windows try removing all of them and see what breaks? >> The only ones I image to be legitimate are VSTEffect.cpp / >> FileNames.cpp / PlatformCompatibility.cpp which all encapsulate >> platform differences. The rest are: >> src/blockfile/ODPCMAliasBlockFile.cpp: #include <windows.h> >> src/blockfile/ODDecodeBlockFile.cpp: #include <windows.h> >> src/blockfile/PCMAliasBlockFile.cpp: #include <windows.h> >> src/blockfile/SimpleBlockFile.cpp: #include <windows.h> >> src/xml/XMLTagHandler.cpp: #include <windows.h> > > OK, I tried removing all the windows.h includes. The only ones that > give compile errors were: > 6>XMLTagHandler.cpp > 6>..\..\..\src\xml\XMLTagHandler.cpp(44) : error C2065: 'MAX_PATH' : > undeclared identifier > 6>..\..\..\src\xml\XMLTagHandler.cpp(56) : error C2065: 'MAX_PATH' : > undeclared identifier > 6>..\..\..\src\xml\XMLTagHandler.cpp(84) : error C2065: 'MAX_PATH' : > undeclared identifier > 6>..\..\..\src\xml\XMLTagHandler.cpp(103) : error C2065: 'MAX_PATH' : > undeclared identifier > > 6>FileNames.cpp > 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'WINAPI' : undeclared > identifier > 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'getmodulehandleex' : > undeclared identifier > 6>..\..\..\src\FileNames.cpp(241) : error C4430: missing type > specifier - int assumed. Note: C++ does not support default-int > 6>..\..\..\src\FileNames.cpp(241) : fatal error C1903: unable to > recover from previous error(s); stopping compilation > > so I put those 2 back in and it all compiles and runs on Release and > Debug, and without any problems in Envelope.h. Shall we remove them > from the code? > > TTFN > Martyn > >> Richard >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. SALE $99.99 this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122412 >> _______________________________________________ >> audacity-devel mailing list >> [hidden email] >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. SALE $99.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122412 > _______________________________________________ > audacity-devel mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/audacity-devel > ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
|
On 1/8/2013 10:48 PM, Leland Lucius wrote:
> > If push comes to shove, just include "dynlib.h" or "wxprec.h" and use > preprocessed headers. > The reason these 2 work is because the include "wx/msw/private.h" and that defines MAX_PATH (yes, to 260). Leland ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
|
In reply to this post by Leland Lucius-2
Hiya Leland
What OS are you on? This is now working fine on VS8 Win7 32-bit here, and I believe also on *nix. Are you on your Mac? TTFN Martyn On 09/01/2013 04:48, Leland Lucius wrote: > I'm getting it in: > > 6>SimpleBlockFile.cpp > 6>..\..\..\src\blockfile\SimpleBlockFile.cpp(502) : error C2065: > 'MAX_PATH' : undeclared identifier > > MAX_PATH is a well know size on Windows and I'd bet my right eye that > it'll never change. (My right eye doesn't work, so a pretty safe bet. :-D) > > How about just adding to Audacity.h: > > #ifdef __WXMSW__ > #include "configwin.h" > #if !defined(MAX_PATH) > #define MAX_PATH 260 > #endif > #undef PLATFORM_MAX_PATH > #define PLATFORM_MAX_PATH MAX_PATH > #endif > > Or even better, change all uses of MAX_PATH to PLATFORM_MAX_PATH and just: > > #ifdef __WXMSW__ > #include "configwin.h" > #undef PLATFORM_MAX_PATH > #define PLATFORM_MAX_PATH 260 > #endif > > If push comes to shove, just include "dynlib.h" or "wxprec.h" and use > preprocessed headers. > > Leland > > On 12/31/2012 1:58 PM, Martyn Shaw wrote: >> >> >> On 31/12/2012 13:29, Richard Ash wrote: >>> On Mon, 31 Dec 2012 02:29:16 +0100 >>> Maarten Baert <[hidden email]> wrote: >>> >>>> On 31/12/12 00:55, Martyn Shaw wrote: >>>>> Also I note that std::max(...) is in use in several other places in >>>>> the Audacity code, without this problem. The only place that I see >>>>> the problem is in Envelope.h and that is also the only .h file in >>>>> which std::max(...) is used. Is that a coincidence, or a clue to >>>>> how to make the code more cross-platform? >>>> It only causes a problem when included from specific source files: >>>> PCMAliasBlockFile.cpp and ODPCMAliasBlockFile.cpp. These are two of >>>> the few files that include <windows.h> directly, rather than >>>> including wxWidgets headers. I assume these are simply the only files >>>> where Envelope.h and windows.h are included at the same time. I don't >>>> quite understand why the BlockFile-related code even has to include >>>> <windows.h> since they don't use any windows-specific functions. >>>> Would removing those break anything? >>> >>> I'd very much like to loose all the #includes of windows.h except where >>> the code is actually platform-dependent. I agree I can see no reason >>> why it is needed in any of the blockfile code. It seems to have been >>> added by Vaughan in 2008 for the switch to DLL (rather than static) >>> wxWidgets, although I can't see why, as most of the commit (r7435) is >>> adding precompilation header includes (which are all wx). >>> >>> Could someone on windows try removing all of them and see what breaks? >>> The only ones I image to be legitimate are VSTEffect.cpp / >>> FileNames.cpp / PlatformCompatibility.cpp which all encapsulate >>> platform differences. The rest are: >>> src/blockfile/ODPCMAliasBlockFile.cpp: #include <windows.h> >>> src/blockfile/ODDecodeBlockFile.cpp: #include <windows.h> >>> src/blockfile/PCMAliasBlockFile.cpp: #include <windows.h> >>> src/blockfile/SimpleBlockFile.cpp: #include <windows.h> >>> src/xml/XMLTagHandler.cpp: #include <windows.h> >> >> OK, I tried removing all the windows.h includes. The only ones that >> give compile errors were: >> 6>XMLTagHandler.cpp >> 6>..\..\..\src\xml\XMLTagHandler.cpp(44) : error C2065: 'MAX_PATH' : >> undeclared identifier >> 6>..\..\..\src\xml\XMLTagHandler.cpp(56) : error C2065: 'MAX_PATH' : >> undeclared identifier >> 6>..\..\..\src\xml\XMLTagHandler.cpp(84) : error C2065: 'MAX_PATH' : >> undeclared identifier >> 6>..\..\..\src\xml\XMLTagHandler.cpp(103) : error C2065: 'MAX_PATH' : >> undeclared identifier >> >> 6>FileNames.cpp >> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'WINAPI' : undeclared >> identifier >> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'getmodulehandleex' : >> undeclared identifier >> 6>..\..\..\src\FileNames.cpp(241) : error C4430: missing type >> specifier - int assumed. Note: C++ does not support default-int >> 6>..\..\..\src\FileNames.cpp(241) : fatal error C1903: unable to >> recover from previous error(s); stopping compilation >> >> so I put those 2 back in and it all compiles and runs on Release and >> Debug, and without any problems in Envelope.h. Shall we remove them >> from the code? >> >> TTFN >> Martyn >> >>> Richard >>> >>> ------------------------------------------------------------------------------ >>> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >>> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >>> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >>> MVPs and experts. SALE $99.99 this month only -- learn more at: >>> http://p.sf.net/sfu/learnmore_122412 >>> _______________________________________________ >>> audacity-devel mailing list >>> [hidden email] >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>> >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. SALE $99.99 this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122412 >> _______________________________________________ >> audacity-devel mailing list >> [hidden email] >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > > ------------------------------------------------------------------------------ > Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery > and much more. Keep your Java skills current with LearnJavaNow - > 200+ hours of step-by-step video tutorials by Java experts. > SALE $49.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122612 > _______________________________________________ > audacity-devel mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/audacity-devel > ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
Administrator
|
Likewise, I'm not seeing this problem. Cleaned the whole directories,
rebuilt. So, Leland, which of your 3 suggestions do you think is best? I haven't had any of the recently reported build problems, updating regularly from SVN. - V On 1/9/2013 3:02 PM, Martyn Shaw wrote: > Hiya Leland > > What OS are you on? This is now working fine on VS8 Win7 32-bit here, > and I believe also on *nix. Are you on your Mac? > > TTFN > Martyn > > On 09/01/2013 04:48, Leland Lucius wrote: >> I'm getting it in: >> >> 6>SimpleBlockFile.cpp >> 6>..\..\..\src\blockfile\SimpleBlockFile.cpp(502) : error C2065: >> 'MAX_PATH' : undeclared identifier >> >> MAX_PATH is a well know size on Windows and I'd bet my right eye that >> it'll never change. (My right eye doesn't work, so a pretty safe bet. :-D) >> >> How about just adding to Audacity.h: >> >> #ifdef __WXMSW__ >> #include "configwin.h" >> #if !defined(MAX_PATH) >> #define MAX_PATH 260 >> #endif >> #undef PLATFORM_MAX_PATH >> #define PLATFORM_MAX_PATH MAX_PATH >> #endif >> >> Or even better, change all uses of MAX_PATH to PLATFORM_MAX_PATH and just: >> >> #ifdef __WXMSW__ >> #include "configwin.h" >> #undef PLATFORM_MAX_PATH >> #define PLATFORM_MAX_PATH 260 >> #endif >> >> If push comes to shove, just include "dynlib.h" or "wxprec.h" and use >> preprocessed headers. >> >> Leland >> >> On 12/31/2012 1:58 PM, Martyn Shaw wrote: >>> >>> >>> On 31/12/2012 13:29, Richard Ash wrote: >>>> On Mon, 31 Dec 2012 02:29:16 +0100 >>>> Maarten Baert <[hidden email]> wrote: >>>> >>>>> On 31/12/12 00:55, Martyn Shaw wrote: >>>>>> Also I note that std::max(...) is in use in several other places in >>>>>> the Audacity code, without this problem. The only place that I see >>>>>> the problem is in Envelope.h and that is also the only .h file in >>>>>> which std::max(...) is used. Is that a coincidence, or a clue to >>>>>> how to make the code more cross-platform? >>>>> It only causes a problem when included from specific source files: >>>>> PCMAliasBlockFile.cpp and ODPCMAliasBlockFile.cpp. These are two of >>>>> the few files that include <windows.h> directly, rather than >>>>> including wxWidgets headers. I assume these are simply the only files >>>>> where Envelope.h and windows.h are included at the same time. I don't >>>>> quite understand why the BlockFile-related code even has to include >>>>> <windows.h> since they don't use any windows-specific functions. >>>>> Would removing those break anything? >>>> >>>> I'd very much like to loose all the #includes of windows.h except where >>>> the code is actually platform-dependent. I agree I can see no reason >>>> why it is needed in any of the blockfile code. It seems to have been >>>> added by Vaughan in 2008 for the switch to DLL (rather than static) >>>> wxWidgets, although I can't see why, as most of the commit (r7435) is >>>> adding precompilation header includes (which are all wx). >>>> >>>> Could someone on windows try removing all of them and see what breaks? >>>> The only ones I image to be legitimate are VSTEffect.cpp / >>>> FileNames.cpp / PlatformCompatibility.cpp which all encapsulate >>>> platform differences. The rest are: >>>> src/blockfile/ODPCMAliasBlockFile.cpp: #include <windows.h> >>>> src/blockfile/ODDecodeBlockFile.cpp: #include <windows.h> >>>> src/blockfile/PCMAliasBlockFile.cpp: #include <windows.h> >>>> src/blockfile/SimpleBlockFile.cpp: #include <windows.h> >>>> src/xml/XMLTagHandler.cpp: #include <windows.h> >>> >>> OK, I tried removing all the windows.h includes. The only ones that >>> give compile errors were: >>> 6>XMLTagHandler.cpp >>> 6>..\..\..\src\xml\XMLTagHandler.cpp(44) : error C2065: 'MAX_PATH' : >>> undeclared identifier >>> 6>..\..\..\src\xml\XMLTagHandler.cpp(56) : error C2065: 'MAX_PATH' : >>> undeclared identifier >>> 6>..\..\..\src\xml\XMLTagHandler.cpp(84) : error C2065: 'MAX_PATH' : >>> undeclared identifier >>> 6>..\..\..\src\xml\XMLTagHandler.cpp(103) : error C2065: 'MAX_PATH' : >>> undeclared identifier >>> >>> 6>FileNames.cpp >>> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'WINAPI' : undeclared >>> identifier >>> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'getmodulehandleex' : >>> undeclared identifier >>> 6>..\..\..\src\FileNames.cpp(241) : error C4430: missing type >>> specifier - int assumed. Note: C++ does not support default-int >>> 6>..\..\..\src\FileNames.cpp(241) : fatal error C1903: unable to >>> recover from previous error(s); stopping compilation >>> >>> so I put those 2 back in and it all compiles and runs on Release and >>> Debug, and without any problems in Envelope.h. Shall we remove them >>> from the code? >>> >>> TTFN >>> Martyn >>> >>>> Richard >>>> ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
|
Sorry guys,
I just ran into this problem again and went to search for the resolution I'd found before and found y'alls questions. I'm running Windows 7 64-bit, VS 2008, and SDK V7.1A. I can't explain why it's happening here and not on y'alls machines. The problem only happens during Release Builds and only happens in: 1>SimpleBlockFile.cpp 1>..\..\..\src\blockfile\SimpleBlockFile.cpp(504) : error C2065: 'MAX_PATH' : undeclared identifier And I know how to "fix" it...just include "<wx/wx.h>". That's actually why most of the other source files don't run into the problem...at some point wx/wx.h get included. Still doesn't explain the problem. Leland On 1/10/2013 12:07 AM, Vaughan Johnson wrote: > Likewise, I'm not seeing this problem. Cleaned the whole directories, > rebuilt. > > So, Leland, which of your 3 suggestions do you think is best? > > I haven't had any of the recently reported build problems, updating > regularly from SVN. > > - V > > > On 1/9/2013 3:02 PM, Martyn Shaw wrote: >> Hiya Leland >> >> What OS are you on? This is now working fine on VS8 Win7 32-bit here, >> and I believe also on *nix. Are you on your Mac? >> >> TTFN >> Martyn >> >> On 09/01/2013 04:48, Leland Lucius wrote: >>> I'm getting it in: >>> >>> 6>SimpleBlockFile.cpp >>> 6>..\..\..\src\blockfile\SimpleBlockFile.cpp(502) : error C2065: >>> 'MAX_PATH' : undeclared identifier >>> >>> MAX_PATH is a well know size on Windows and I'd bet my right eye that >>> it'll never change. (My right eye doesn't work, so a pretty safe bet. :-D) >>> >>> How about just adding to Audacity.h: >>> >>> #ifdef __WXMSW__ >>> #include "configwin.h" >>> #if !defined(MAX_PATH) >>> #define MAX_PATH 260 >>> #endif >>> #undef PLATFORM_MAX_PATH >>> #define PLATFORM_MAX_PATH MAX_PATH >>> #endif >>> >>> Or even better, change all uses of MAX_PATH to PLATFORM_MAX_PATH and just: >>> >>> #ifdef __WXMSW__ >>> #include "configwin.h" >>> #undef PLATFORM_MAX_PATH >>> #define PLATFORM_MAX_PATH 260 >>> #endif >>> >>> If push comes to shove, just include "dynlib.h" or "wxprec.h" and use >>> preprocessed headers. >>> >>> Leland >>> >>> On 12/31/2012 1:58 PM, Martyn Shaw wrote: >>>> >>>> >>>> On 31/12/2012 13:29, Richard Ash wrote: >>>>> On Mon, 31 Dec 2012 02:29:16 +0100 >>>>> Maarten Baert <[hidden email]> wrote: >>>>> >>>>>> On 31/12/12 00:55, Martyn Shaw wrote: >>>>>>> Also I note that std::max(...) is in use in several other places in >>>>>>> the Audacity code, without this problem. The only place that I see >>>>>>> the problem is in Envelope.h and that is also the only .h file in >>>>>>> which std::max(...) is used. Is that a coincidence, or a clue to >>>>>>> how to make the code more cross-platform? >>>>>> It only causes a problem when included from specific source files: >>>>>> PCMAliasBlockFile.cpp and ODPCMAliasBlockFile.cpp. These are two of >>>>>> the few files that include <windows.h> directly, rather than >>>>>> including wxWidgets headers. I assume these are simply the only files >>>>>> where Envelope.h and windows.h are included at the same time. I don't >>>>>> quite understand why the BlockFile-related code even has to include >>>>>> <windows.h> since they don't use any windows-specific functions. >>>>>> Would removing those break anything? >>>>> >>>>> I'd very much like to loose all the #includes of windows.h except where >>>>> the code is actually platform-dependent. I agree I can see no reason >>>>> why it is needed in any of the blockfile code. It seems to have been >>>>> added by Vaughan in 2008 for the switch to DLL (rather than static) >>>>> wxWidgets, although I can't see why, as most of the commit (r7435) is >>>>> adding precompilation header includes (which are all wx). >>>>> >>>>> Could someone on windows try removing all of them and see what breaks? >>>>> The only ones I image to be legitimate are VSTEffect.cpp / >>>>> FileNames.cpp / PlatformCompatibility.cpp which all encapsulate >>>>> platform differences. The rest are: >>>>> src/blockfile/ODPCMAliasBlockFile.cpp: #include <windows.h> >>>>> src/blockfile/ODDecodeBlockFile.cpp: #include <windows.h> >>>>> src/blockfile/PCMAliasBlockFile.cpp: #include <windows.h> >>>>> src/blockfile/SimpleBlockFile.cpp: #include <windows.h> >>>>> src/xml/XMLTagHandler.cpp: #include <windows.h> >>>> >>>> OK, I tried removing all the windows.h includes. The only ones that >>>> give compile errors were: >>>> 6>XMLTagHandler.cpp >>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(44) : error C2065: 'MAX_PATH' : >>>> undeclared identifier >>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(56) : error C2065: 'MAX_PATH' : >>>> undeclared identifier >>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(84) : error C2065: 'MAX_PATH' : >>>> undeclared identifier >>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(103) : error C2065: 'MAX_PATH' : >>>> undeclared identifier >>>> >>>> 6>FileNames.cpp >>>> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'WINAPI' : undeclared >>>> identifier >>>> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'getmodulehandleex' : >>>> undeclared identifier >>>> 6>..\..\..\src\FileNames.cpp(241) : error C4430: missing type >>>> specifier - int assumed. Note: C++ does not support default-int >>>> 6>..\..\..\src\FileNames.cpp(241) : fatal error C1903: unable to >>>> recover from previous error(s); stopping compilation >>>> >>>> so I put those 2 back in and it all compiles and runs on Release and >>>> Debug, and without any problems in Envelope.h. Shall we remove them >>>> from the code? >>>> >>>> TTFN >>>> Martyn >>>> >>>>> Richard >>>>> > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122712 > _______________________________________________ > audacity-devel mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/audacity-devel > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
Administrator
|
Builds for me.
- V On 2/26/2013 7:37 PM, Leland wrote: > Sorry guys, > > I just ran into this problem again and went to search for the resolution > I'd found before and found y'alls questions. > > I'm running Windows 7 64-bit, VS 2008, and SDK V7.1A. > > I can't explain why it's happening here and not on y'alls machines. The > problem only happens during Release Builds and only happens in: > > 1>SimpleBlockFile.cpp > 1>..\..\..\src\blockfile\SimpleBlockFile.cpp(504) : error C2065: > 'MAX_PATH' : undeclared identifier > > And I know how to "fix" it...just include "<wx/wx.h>". That's actually > why most of the other source files don't run into the problem...at some > point wx/wx.h get included. > > Still doesn't explain the problem. > > Leland > > On 1/10/2013 12:07 AM, Vaughan Johnson wrote: >> Likewise, I'm not seeing this problem. Cleaned the whole directories, >> rebuilt. >> >> So, Leland, which of your 3 suggestions do you think is best? >> >> I haven't had any of the recently reported build problems, updating >> regularly from SVN. >> >> - V >> >> >> On 1/9/2013 3:02 PM, Martyn Shaw wrote: >>> Hiya Leland >>> >>> What OS are you on? This is now working fine on VS8 Win7 32-bit here, >>> and I believe also on *nix. Are you on your Mac? >>> >>> TTFN >>> Martyn >>> >>> On 09/01/2013 04:48, Leland Lucius wrote: >>>> I'm getting it in: >>>> >>>> 6>SimpleBlockFile.cpp >>>> 6>..\..\..\src\blockfile\SimpleBlockFile.cpp(502) : error C2065: >>>> 'MAX_PATH' : undeclared identifier >>>> >>>> MAX_PATH is a well know size on Windows and I'd bet my right eye that >>>> it'll never change. (My right eye doesn't work, so a pretty safe bet. :-D) >>>> >>>> How about just adding to Audacity.h: >>>> >>>> #ifdef __WXMSW__ >>>> #include "configwin.h" >>>> #if !defined(MAX_PATH) >>>> #define MAX_PATH 260 >>>> #endif >>>> #undef PLATFORM_MAX_PATH >>>> #define PLATFORM_MAX_PATH MAX_PATH >>>> #endif >>>> >>>> Or even better, change all uses of MAX_PATH to PLATFORM_MAX_PATH and just: >>>> >>>> #ifdef __WXMSW__ >>>> #include "configwin.h" >>>> #undef PLATFORM_MAX_PATH >>>> #define PLATFORM_MAX_PATH 260 >>>> #endif >>>> >>>> If push comes to shove, just include "dynlib.h" or "wxprec.h" and use >>>> preprocessed headers. >>>> >>>> Leland >>>> >>>> On 12/31/2012 1:58 PM, Martyn Shaw wrote: >>>>> >>>>> >>>>> On 31/12/2012 13:29, Richard Ash wrote: >>>>>> On Mon, 31 Dec 2012 02:29:16 +0100 >>>>>> Maarten Baert <[hidden email]> wrote: >>>>>> >>>>>>> On 31/12/12 00:55, Martyn Shaw wrote: >>>>>>>> Also I note that std::max(...) is in use in several other places in >>>>>>>> the Audacity code, without this problem. The only place that I see >>>>>>>> the problem is in Envelope.h and that is also the only .h file in >>>>>>>> which std::max(...) is used. Is that a coincidence, or a clue to >>>>>>>> how to make the code more cross-platform? >>>>>>> It only causes a problem when included from specific source files: >>>>>>> PCMAliasBlockFile.cpp and ODPCMAliasBlockFile.cpp. These are two of >>>>>>> the few files that include <windows.h> directly, rather than >>>>>>> including wxWidgets headers. I assume these are simply the only files >>>>>>> where Envelope.h and windows.h are included at the same time. I don't >>>>>>> quite understand why the BlockFile-related code even has to include >>>>>>> <windows.h> since they don't use any windows-specific functions. >>>>>>> Would removing those break anything? >>>>>> >>>>>> I'd very much like to loose all the #includes of windows.h except where >>>>>> the code is actually platform-dependent. I agree I can see no reason >>>>>> why it is needed in any of the blockfile code. It seems to have been >>>>>> added by Vaughan in 2008 for the switch to DLL (rather than static) >>>>>> wxWidgets, although I can't see why, as most of the commit (r7435) is >>>>>> adding precompilation header includes (which are all wx). >>>>>> >>>>>> Could someone on windows try removing all of them and see what breaks? >>>>>> The only ones I image to be legitimate are VSTEffect.cpp / >>>>>> FileNames.cpp / PlatformCompatibility.cpp which all encapsulate >>>>>> platform differences. The rest are: >>>>>> src/blockfile/ODPCMAliasBlockFile.cpp: #include <windows.h> >>>>>> src/blockfile/ODDecodeBlockFile.cpp: #include <windows.h> >>>>>> src/blockfile/PCMAliasBlockFile.cpp: #include <windows.h> >>>>>> src/blockfile/SimpleBlockFile.cpp: #include <windows.h> >>>>>> src/xml/XMLTagHandler.cpp: #include <windows.h> >>>>> >>>>> OK, I tried removing all the windows.h includes. The only ones that >>>>> give compile errors were: >>>>> 6>XMLTagHandler.cpp >>>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(44) : error C2065: 'MAX_PATH' : >>>>> undeclared identifier >>>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(56) : error C2065: 'MAX_PATH' : >>>>> undeclared identifier >>>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(84) : error C2065: 'MAX_PATH' : >>>>> undeclared identifier >>>>> 6>..\..\..\src\xml\XMLTagHandler.cpp(103) : error C2065: 'MAX_PATH' : >>>>> undeclared identifier >>>>> >>>>> 6>FileNames.cpp >>>>> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'WINAPI' : undeclared >>>>> identifier >>>>> 6>..\..\..\src\FileNames.cpp(241) : error C2065: 'getmodulehandleex' : >>>>> undeclared identifier >>>>> 6>..\..\..\src\FileNames.cpp(241) : error C4430: missing type >>>>> specifier - int assumed. Note: C++ does not support default-int >>>>> 6>..\..\..\src\FileNames.cpp(241) : fatal error C1903: unable to >>>>> recover from previous error(s); stopping compilation >>>>> >>>>> so I put those 2 back in and it all compiles and runs on Release and >>>>> Debug, and without any problems in Envelope.h. Shall we remove them >>>>> from the code? >>>>> >>>>> TTFN >>>>> Martyn >>>>> >>>>>> Richard >>>>>> >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. ON SALE this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122712 >> _______________________________________________ >> audacity-devel mailing list >> [hidden email] >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_feb > _______________________________________________ > audacity-devel mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/audacity-devel > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
Administrator
|
In reply to this post by Leland (Audacity Team)
Leland wrote:
> I just ran into this problem again and went to search for the > resolution I'd found before and found y'alls questions. > > I'm running Windows 7 64-bit, VS 2008, and SDK V7.1A. > > I can't explain why it's happening here and not on y'alls machines. The > problem only happens during Release Builds and only happens in: > > 1>SimpleBlockFile.cpp > 1>..\..\..\src\blockfile\SimpleBlockFile.cpp(504) : error C2065: > 'MAX_PATH' : undeclared identifier > > > And I know how to "fix" it...just include "<wx/wx.h>". That's actually > why most of the other source files don't run into the problem...at some > point wx/wx.h get included. > > Still doesn't explain the problem. A user on the Forum on Windows 7, VS C++ 2008 Express had this issue too, but he said he was using the SDK V6.0a then updated to V7.1. Might that be relevant? My machine was a fresh installation of the V7.1 SDK then fresh installation of VS C++ 2008 Express. Your solution above compiles for me fine in Release and Debug builds. His solution FWIW was: Index: src/Audacity.h ==================================== --- src/Audacity.h (revision 12261) +++ src/Audacity.h (working copy) @@ -99,7 +99,7 @@ #ifdef __WXMSW__ #include "configwin.h" #undef PLATFORM_MAX_PATH -#define PLATFORM_MAX_PATH MAX_PATH +#define PLATFORM_MAX_PATH 260 #endif /* Magic for dynamic library import and export. This is unfortunately Gale |
Win 7 SDK vs MVSC (was Re: TimeTracks)
|
Administrator
|
On 3/17/2013 7:07 PM, Gale (Audacity Team) wrote:
> Leland wrote: >> I just ran into this problem again and went to search for the >> resolution I'd found before and found y'alls questions. >> >> I'm running Windows 7 64-bit, VS 2008, and SDK V7.1A. >> >> I can't explain why it's happening here and not on y'alls machines. The >> problem only happens during Release Builds and only happens in: >> >> 1>SimpleBlockFile.cpp >> 1>..\..\..\src\blockfile\SimpleBlockFile.cpp(504) : error C2065: >> 'MAX_PATH' : undeclared identifier Again, not getting that error on rebuild debug or release, Windows 7 64bit, VS 2008, SDK 6 -- standard installation. Aren't SDK 7 and 7.1 primarily for MSVC 2010? Yes, there are articles about making it work with MSVC 2008, but I don't think it's mainstream, right? And we discussed long ago the very good reasons to not convert to MSVC 2010, right? What was actually broken about min and max or wxMin and wxMax? Why is this taking so much attention? What does this have to do any more with "Time Tracks" (original and continuing subject until this msg)? This thread has strayed so far... what's the continuing point? >> >> >> And I know how to "fix" it...just include "<wx/wx.h>". That's actually >> why most of the other source files don't run into the problem...at some >> point wx/wx.h get included. So why not do that? MAX_PATH is Windows specific. I don't know why there was such an effort to purge wx.h a few months ago. Platform issues are what it's supposed to handle, right? >> >> Still doesn't explain the problem. > > A user on the Forum on Windows 7, VS C++ 2008 Express had this issue too, > but he said he was using the SDK V6.0a then updated to V7.1. Might that be > relevant? My machine was a fresh installation of the V7.1 SDK then fresh > installation of VS C++ 2008 Express. > > Your solution above compiles for me fine in Release and Debug builds. His > solution FWIW was: > > Index: src/Audacity.h > ==================================== > > --- src/Audacity.h (revision 12261) > +++ src/Audacity.h (working copy) > @@ -99,7 +99,7 @@ > #ifdef __WXMSW__ > #include "configwin.h" > #undef PLATFORM_MAX_PATH > -#define PLATFORM_MAX_PATH MAX_PATH > +#define PLATFORM_MAX_PATH 260 > #endif > Bad solution. It duplicates a platform-specific constant in our code. If the platform constant changes, we would have to update. Yes, unlikely in this case, but bad practice. -1. - V ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
|
Administrator
|
| From Vaughan Johnson <[hidden email]> | Mon, 18 Mar 2013 22:24:34 -0700 | Subject: [Audacity-devel] Win 7 SDK vs MVSC (was Re: TimeTracks) > On 3/17/2013 7:07 PM, Gale (Audacity Team) wrote: > > Leland wrote: > >> I just ran into this problem again and went to search for the > >> resolution I'd found before and found y'alls questions. > >> > >> I'm running Windows 7 64-bit, VS 2008, and SDK V7.1A. > >> > >> I can't explain why it's happening here and not on y'alls machines. The > >> problem only happens during Release Builds and only happens in: > >> > >> 1>SimpleBlockFile.cpp > >> 1>..\..\..\src\blockfile\SimpleBlockFile.cpp(504) : error C2065: > >> 'MAX_PATH' : undeclared identifier > > Again, not getting that error on rebuild debug or release, Windows 7 > 64bit, VS 2008, SDK 6 -- standard installation. > > Aren't SDK 7 and 7.1 primarily for MSVC 2010? Yes, there are articles > about making it work with MSVC 2008, but I don't think it's mainstream, > right? And we discussed long ago the very good reasons to not convert to > MSVC 2010, right? I have built widgets and Audacity from scratch three times on different Win 7 machines using SDK 7.1. Personally I have never seen this compile problem. But while yes, SDK 7 and 7.1 are primarily for MSVC 2010, they still (apparently, in the main) support MSVC 2005 and 2008. Click "System Requirements" after clicking this link: http://tinyurl.com/66tgu3w . The problem is that the older SDK 6 (whenever I have seen it) doesn't state support for Windows 7 (probably because it didn't exist then). I wouldn't want to risk using SDK 6 on Win 7, especially SP1. > What was actually broken about min and max or wxMin and wxMax? Why is > this taking so much attention? > > What does this have to do any more with "Time Tracks" (original and > continuing subject until this msg)? > > This thread has strayed so far... what's the continuing point? Sorry but I was on Nabble, so I could not change the subject in my last post. The continuing point was to note that a user has also run across this issue. > >> And I know how to "fix" it...just include "<wx/wx.h>". That's actually > >> why most of the other source files don't run into the problem...at some > >> point wx/wx.h get included. > > So why not do that? As stated, I can build Release and Debug if you "fix" it that way, Leland. There is no reason adding an include will break anything is there? Gale > MAX_PATH is Windows specific. I don't know why there > was such an effort to purge wx.h a few months ago. Platform issues are > what it's supposed to handle, right? > > > > >> > >> Still doesn't explain the problem. > > > > A user on the Forum on Windows 7, VS C++ 2008 Express had this issue too, > > but he said he was using the SDK V6.0a then updated to V7.1. Might that be > > relevant? My machine was a fresh installation of the V7.1 SDK then fresh > > installation of VS C++ 2008 Express. > > > > Your solution above compiles for me fine in Release and Debug builds. His > > solution FWIW was: > > > > Index: src/Audacity.h > > ==================================== > > > > --- src/Audacity.h (revision 12261) > > +++ src/Audacity.h (working copy) > > @@ -99,7 +99,7 @@ > > #ifdef __WXMSW__ > > #include "configwin.h" > > #undef PLATFORM_MAX_PATH > > -#define PLATFORM_MAX_PATH MAX_PATH > > +#define PLATFORM_MAX_PATH 260 > > #endif > > > > Bad solution. It duplicates a platform-specific constant in our code. If > the platform constant changes, we would have to update. Yes, unlikely in > this case, but bad practice. > > -1. > > > - V ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
Re: Win 7 SDK vs MVSC (was Re: TimeTracks)
|
Administrator
|
On 3/19/2013 1:53 AM, Gale Andrews wrote:
> > | From Vaughan Johnson <[hidden email]> > | Mon, 18 Mar 2013 22:24:34 -0700 >> On 3/17/2013 7:07 PM, Gale (Audacity Team) wrote: >>> Leland wrote: >>>> I just ran into this problem again and went to search for the >>>> resolution I'd found before and found y'alls questions. >>>> >>>> I'm running Windows 7 64-bit, VS 2008, and SDK V7.1A. >>>> >>>> I can't explain why it's happening here and not on y'alls machines. The >>>> problem only happens during Release Builds and only happens in: >>>> >>>> 1>SimpleBlockFile.cpp >>>> 1>..\..\..\src\blockfile\SimpleBlockFile.cpp(504) : error C2065: >>>> 'MAX_PATH' : undeclared identifier >> >> Again, not getting that error on rebuild debug or release, Windows 7 >> 64bit, VS 2008, SDK 6 -- standard installation. >> >> Aren't SDK 7 and 7.1 primarily for MSVC 2010? Yes, there are articles >> about making it work with MSVC 2008, but I don't think it's mainstream, >> right? I sure don't see anywhere Microsoft promotes it. More reasonable to use the SDK contemporary with the VS version, I think -- that combination is what MS released. >And we discussed long ago the very good reasons to not convert to >> MSVC 2010, right? > > I have built widgets and Audacity from scratch three times on > different Win 7 machines using SDK 7.1. Personally I have never > seen this compile problem. > > But while yes, SDK 7 and 7.1 are primarily for MSVC 2010, they still > (apparently, in the main) support MSVC 2005 and 2008. Click "System > Requirements" after clicking this link: > http://tinyurl.com/66tgu3w . Well, that doesn't say Windows 8, so if we're going to do this, shouldn't we upgrade to VS 2012 and the 2012 SDK, rather than from obsolete to less obsolete? Reviews of VS 2012 are certainly a lot better than those for VS 2010, at about 6 months after release. Drawback is that the oldest (non-server) version of Windows that can run VS 2012 is Win 7, but Martyn and I (at least) have Win 7. > > The problem is that the older SDK 6 (whenever I have seen it) doesn't > state support for Windows 7 (probably because it didn't exist then). > I wouldn't want to risk using SDK 6 on Win 7, especially SP1. What risk is there? Typically, they maintain backward compatibility, right? And I'd especially think so about our using SDK 6 and MSVC 2008, because MSVC2010 was such a disaster. The changes are usually about new features, I think. > > >> What was actually broken about min and max or wxMin and wxMax? Why is >> this taking so much attention? >> >> [...] > The continuing point was to note that a user has also run > across this issue. User running into a compile issue? So we have a count of two people with this compile problem? > > >>>> And I know how to "fix" it...just include "<wx/wx.h>". That's actually >>>> why most of the other source files don't run into the problem...at some >>>> point wx/wx.h get included. >> >> So why not do that? > > As stated, I can build Release and Debug if you "fix" it that way, > Leland. Yes, I saw what you stated. I was looking for response from whomever took it out, as there was probably a reason. > > There is no reason adding an include will break anything is there? Sure, possibly, depending on its contents. In this case, unlikely. - V ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
«
Return to audacity-devel
|
1 view|%1 views
| Free forum by Nabble | Edit this page |