Wrong return values and Mac build, and an error in wxWidgets

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Wrong return values and Mac build, and an error in wxWidgets

Paul Licameli
I fixed the recent errors I introduced into the Windows build, because functions had wrongly typed returns.

I figured out how to change the settings for Mac build so that such errors are not forgiven.

I fixed a few errors this uncovered.

But guess what?  It also uncovers a non-void function that returns nothing, in one of the wxWidgets headers!

For that reason, I reverted the change in the Xcode project, but now I may want to make a one line change to our custom build of wxWidgets headers, just to fix this.

PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Wrong return values and Mac build, and an error in wxWidgets

MartynShaw
Hi Paul

Have you reported back to the wx folk?  It might be useful in the long run.

TTFN
Martyn

On 25 June 2017 at 21:04, Paul Licameli <[hidden email]> wrote:
I fixed the recent errors I introduced into the Windows build, because functions had wrongly typed returns.

I figured out how to change the settings for Mac build so that such errors are not forgiven.

I fixed a few errors this uncovered.

But guess what?  It also uncovers a non-void function that returns nothing, in one of the wxWidgets headers!

For that reason, I reverted the change in the Xcode project, but now I may want to make a one line change to our custom build of wxWidgets headers, just to fix this.

PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Wrong return values and Mac build, and an error in wxWidgets

Paul Licameli
Oh, this is embarrassing:  That error was introduced only in one of the wxWidgets patches that I wrote for our previous release.  It's not in their source!

PRL



On Sun, Jun 25, 2017 at 6:58 PM, Martyn Shaw <[hidden email]> wrote:
Hi Paul

Have you reported back to the wx folk?  It might be useful in the long run.

TTFN
Martyn

On 25 June 2017 at 21:04, Paul Licameli <[hidden email]> wrote:
I fixed the recent errors I introduced into the Windows build, because functions had wrongly typed returns.

I figured out how to change the settings for Mac build so that such errors are not forgiven.

I fixed a few errors this uncovered.

But guess what?  It also uncovers a non-void function that returns nothing, in one of the wxWidgets headers!

For that reason, I reverted the change in the Xcode project, but now I may want to make a one line change to our custom build of wxWidgets headers, just to fix this.

PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Wrong return values and Mac build, and an error in wxWidgets

Paul Licameli


On Mon, Jun 26, 2017 at 12:18 PM, Paul Licameli <[hidden email]> wrote:
Oh, this is embarrassing:  That error was introduced only in one of the wxWidgets patches that I wrote for our previous release.  It's not in their source!

PRL

I added this inline function to a header file, and I made its return type bool, but returned no value, but neither did I use the return value anywhere.  So it is a harmless error.  But I must fix it if I want to change Mac build settings so that it can catch errors of this kind.

PRL

 



On Sun, Jun 25, 2017 at 6:58 PM, Martyn Shaw <[hidden email]> wrote:
Hi Paul

Have you reported back to the wx folk?  It might be useful in the long run.

TTFN
Martyn

On 25 June 2017 at 21:04, Paul Licameli <[hidden email]> wrote:
I fixed the recent errors I introduced into the Windows build, because functions had wrongly typed returns.

I figured out how to change the settings for Mac build so that such errors are not forgiven.

I fixed a few errors this uncovered.

But guess what?  It also uncovers a non-void function that returns nothing, in one of the wxWidgets headers!

For that reason, I reverted the change in the Xcode project, but now I may want to make a one line change to our custom build of wxWidgets headers, just to fix this.

PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Wrong return values and Mac build, and an error in wxWidgets

MartynShaw
In reply to this post by Paul Licameli
:-)


On 26 Jun 2017 17:21, "Paul Licameli" <[hidden email]> wrote:
Oh, this is embarrassing:  That error was introduced only in one of the wxWidgets patches that I wrote for our previous release.  It's not in their source!

PRL



On Sun, Jun 25, 2017 at 6:58 PM, Martyn Shaw <[hidden email]> wrote:
Hi Paul

Have you reported back to the wx folk?  It might be useful in the long run.

TTFN
Martyn

On 25 June 2017 at 21:04, Paul Licameli <[hidden email]> wrote:
I fixed the recent errors I introduced into the Windows build, because functions had wrongly typed returns.

I figured out how to change the settings for Mac build so that such errors are not forgiven.

I fixed a few errors this uncovered.

But guess what?  It also uncovers a non-void function that returns nothing, in one of the wxWidgets headers!

For that reason, I reverted the change in the Xcode project, but now I may want to make a one line change to our custom build of wxWidgets headers, just to fix this.

PRL


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...